Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type to webpack .mjs module rule #58572

Closed
wants to merge 1 commit into from

Conversation

stefanprobst
Copy link
Contributor

this fixes an issue i ran into when importing the shikiji package.

see here for a reproduction of the issue: https://github.com/stefanprobst/issue-next-webpack-shikiji (which leads to: "export 'getHighlighterCore' (reexported as 'getHighlighterCore') was not found in './core.mjs' (module has no exports)")

x-ref: #17806
x-ref: antfu/shikiji#13 (comment)

@ijjk
Copy link
Member

ijjk commented Nov 17, 2023

Allow CI Workflow Run

  • approve CI run for commit: 236f603

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Nov 17, 2023

Allow CI Workflow Run

  • approve CI run for commit: 236f603

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 17, 2023

Allow CI Workflow Run

  • approve CI run for commit: 236f603

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@huozhi huozhi closed this in #58967 Dec 1, 2023
@stefanprobst stefanprobst deleted the fix/mjs-webpack branch December 1, 2023 14:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants