Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): switch default from yarn to npm in Dockerfiles #61348

Merged
merged 4 commits into from
Jan 29, 2024
Merged

chore(examples): switch default from yarn to npm in Dockerfiles #61348

merged 4 commits into from
Jan 29, 2024

Conversation

samcx
Copy link
Member

@samcx samcx commented Jan 29, 2024 •
edited by padmaia
Loading

Changes

Closes NEXT-2291

@samcx samcx self-assigned this Jan 29, 2024
@samcx samcx requested review from a team as code owners January 29, 2024 20:55
@samcx samcx requested review from ismaelrumzan and lydiahallie and removed request for a team January 29, 2024 20:55
@ijjk ijjk added examples Issue was opened via the examples template. created-by: Next.js team PRs by the Next.js team. labels Jan 29, 2024
styfle
styfle reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use corepack

https://styfle.dev/blog/corepack

@samcx samcx requested a review from styfle January 29, 2024 21:33
@samcx samcx merged commit 8d13ab9 into vercel:canary Jan 29, 2024
29 checks passed
@samcx samcx deleted the sam/examples/with-docker-multi-env branch January 29, 2024 22:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan was automatically assigned from vercel/devex

@lydiahallie lydiahallie Awaiting requested review from lydiahallie lydiahallie was automatically assigned from vercel/devex

Assignees

@samcx samcx

Labels
created-by: Next.js team PRs by the Next.js team. examples Issue was opened via the examples template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Use npm i -g Instead of yarn global add on Dockerfile Example
3 participants
@samcx @styfle @ijjk