[with-typescript] Improved intial props examples, added example detail #6165
+126
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a TS file has no JSX syntax, we don't need the `.tsx` extension
I've just thought of a way to improve the initial props page by adding an example for a list/detail page structure. To do that, I've created a separate `/detail` page, and a mock API which calls data from the array we made on the previous PR. A ListDetail component is created as an example for displaying detail. Page structure is also cleaned up. Should I go ahead and add an example on how to style with styled-jsx + its TS declarations? I might decide to do it within this week anyway.
resir014
commented
Jan 28, 2019
| if (errors) { | ||
| return ( | ||
| <Layout title={`Error | Next.js + TypeScript Example`}> | ||
| <p><span style={{ color: 'red' }}>Error:</span> {errors}</p> |
There was a problem hiding this comment.
Not sure if I should show an example to extend the default Error component or not. 🤔
|
Just synced this PR with upstream. |
timneutkens
reviewed
Jan 31, 2019
| import IDataObject from '../interfaces' | ||
|
|
||
| type Props = { | ||
| data: IDataObject, | ||
| } | ||
|
|
||
| const ListItem: React.FunctionComponent<Props> = ({ data }) => ( | ||
| <React.Fragment>{data.id}:{data.name}</React.Fragment> | ||
| <Link href={`/detail?id=${data.id}`} passHref> |
There was a problem hiding this comment.
passHref is not required on Link tags, or is it when using typescript?
There was a problem hiding this comment.
It should be fine without passHref, I'm just used to putting that in for Links. 😅
resir014
added a commit
to resir014/next.js
that referenced
this pull request
Feb 10, 2019
As per discussion in vercel#6165, I removed the `passHref` in `Link` as they're unnecessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just thought of a way to improve the initial props page by adding
an example for a list/detail page structure. To do that, I've created a
separate
/detailpage, and a mock API which calls data from the arraywe made on the previous PR.
A ListDetail component is created as an example for displaying detail.
Page structure is also cleaned up. Should I go ahead and add an example
on how to style with styled-jsx + its TS declarations? I might decide to
do it within this week anyway.