[WIP] Better .babelrc support #620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunoda
commented
Jan 2, 2017
| @@ -202,7 +202,7 @@ gulp.task('release', (cb) => { | |||
| 'compile', | |||
| 'build', | |||
| 'copy', | |||
| 'test' | |||
There was a problem hiding this comment.
Currently, tests are failing.
I'll work on a fix.
arunoda
force-pushed
the
better-babelrc-support
branch
from
8034978 to
8f8b5a7
Compare
arunoda
commented
Jan 2, 2017
| @@ -187,7 +193,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false | |||
| resolve: { | |||
| modules: [ | |||
| nextNodeModulesDir, | |||
| 'node_modules' | |||
| appNodeModulesDir | |||
There was a problem hiding this comment.
Had to set this, otherwise webpack raise issues that, it can't find next/* apis.
arunoda
commented
Jan 2, 2017
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
This is just to to fool our .babelrc finding logic to stop here.
|
I'm not sure if we shoud do this since it mean to change the behavior babel users might expect. |
|
Yeah. I am not sure about this either. Let's keep this open until it's really really needed. |
|
For now, we'll fix our examples, and re-consider this if it creates problems for others. I'll favor less code an maintain the (undesirable!) babel default |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we are only looking for
.babelrcupto the closest directory with apackage.json.This will fix the
.babelrcissue discussed in #560