Update to `turbopack-240215.5` #62119

wbinnssmith · 2024-02-15T21:32:30Z

Includes:

Turbopack react-refresh: compare boundary signatures, not exports turborepo#7401

This makes “conversion to class component” Turbopack tests pass.

Includes: - vercel/turborepo#7401 This makes “conversion to class component” Turbopack tests pass.

ijjk · 2024-02-15T21:44:46Z

Failing test suites

Commit: e4301b7

pnpm test-dev test/e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts (PPR)

interception-route-prefetch-cache > runtime = edge > should render the correct interception when two distinct layouts share the same path structure

Expand output

● interception-route-prefetch-cache › runtime = edge › should render the correct interception when two distinct layouts share the same path structure

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

   6 | describe('interception-route-prefetch-cache', () => {
   7 |   function runTests({ next }: ReturnType<typeof nextTestSetup>) {
>  8 |     it('should render the correct interception when two distinct layouts share the same path structure', async () => {
     |     ^
   9 |       const browser = await next.browser('/')
  10 |
  11 |       await browser.elementByCss('[href="/foo"]').click()

  at it (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:8:5)
  at runTests (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:91:5)
  at describe (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:90:3)
  at Object.describe (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:6:1)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts

app dir - navigation > navigation between pages and app > should not continously initiate a mpa navigation to the same URL when router state changes
app dir - navigation > query string > should handle unicode search params

Expand output

● app dir - navigation › query string › should handle unicode search params

request.response: Target page, context or browser has been closed

  37 |         const browser = await next.browser('/search-params?name=名')
  38 |         async function requestHandler(req: Request) {
> 39 |           const res = await req.response()
     |                                 ^
  40 |           if (!res) return
  41 |
  42 |           requests.push({

  at response (e2e/app-dir/navigation/navigation.test.ts:39:33)
  at cb (lib/browsers/playwright.ts:234:51)
  at Page.forEach (lib/browsers/playwright.ts:234:35)

● app dir - navigation › navigation between pages and app › should not continously initiate a mpa navigation to the same URL when router state changes

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#link-to-slow-page')
  -   locator resolved to visible <a href="/slow-page" id="link-to-slow-page">To /slow-page</a>

  421 |     return this.chain(() => {
  422 |       return page
> 423 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  424 |         .then(async (el) => {
  425 |           // it seems selenium waits longer and tests rely on this behavior
  426 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:423:10)

Read more about building and testing Next.js in contributing.md.

ijjk · 2024-02-15T21:49:30Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
buildDuration	20.1s	20.2s	⚠️ +109ms
buildDurationCached	8.7s	7.5s	N/A
nodeModulesSize	196 MB	196 MB	✓
nextStartRea..uration (ms)	431ms	427ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
1068-HASH.js gzip	30.3 kB	30.3 kB	N/A
3f784ff6-HASH.js gzip	53.5 kB	53.5 kB	N/A
4944-HASH.js gzip	5.04 kB	5.03 kB	N/A
8423.HASH.js gzip	181 B	181 B	✓
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	243 B	241 B	N/A
main-HASH.js gzip	32.1 kB	32.1 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	47.1 kB	47.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
_app-HASH.js gzip	196 B	196 B	✓
_error-HASH.js gzip	184 B	183 B	N/A
amp-HASH.js gzip	503 B	504 B	N/A
css-HASH.js gzip	323 B	324 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.51 kB	N/A
edge-ssr-HASH.js gzip	258 B	259 B	N/A
head-HASH.js gzip	353 B	351 B	N/A
hooks-HASH.js gzip	370 B	370 B	✓
image-HASH.js gzip	4.21 kB	4.2 kB	N/A
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.68 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	313 B	314 B	N/A
script-HASH.js gzip	386 B	385 B	N/A
withRouter-HASH.js gzip	309 B	311 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	931 B	931 B	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
_buildManifest.js gzip	485 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
index.html gzip	528 B	528 B	✓
link.html gzip	540 B	541 B	N/A
withRouter.html gzip	523 B	523 B	✓
Overall change	1.05 kB	1.05 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
edge-ssr.js gzip	94.4 kB	94.5 kB	N/A
page.js gzip	151 kB	151 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
middleware-b..fest.js gzip	623 B	626 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	44.4 kB	44.4 kB	N/A
edge-runtime..pack.js gzip	1.94 kB	1.94 kB	✓
Overall change	2.1 kB	2.1 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
app-page-exp...dev.js gzip	166 kB	166 kB	✓
app-page-exp..prod.js gzip	95.6 kB	95.6 kB	✓
app-page-tur..prod.js gzip	97.3 kB	97.3 kB	✓
app-page-tur..prod.js gzip	91.8 kB	91.8 kB	✓
app-page.run...dev.js gzip	136 kB	136 kB	✓
app-page.run..prod.js gzip	90.3 kB	90.3 kB	✓
app-route-ex...dev.js gzip	22 kB	22 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.6 kB	14.6 kB	✓
app-route.ru...dev.js gzip	21.7 kB	21.7 kB	✓
app-route.ru..prod.js gzip	14.6 kB	14.6 kB	✓
pages-api-tu..prod.js gzip	9.43 kB	9.43 kB	✓
pages-api.ru...dev.js gzip	9.7 kB	9.7 kB	✓
pages-api.ru..prod.js gzip	9.43 kB	9.43 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	22.7 kB	22.7 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	50 kB	50 kB	✓
Overall change	925 kB	925 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js wbinnssmith/turbopack-240215.5	Change
0.pack gzip	1.55 MB	1.55 MB	⚠️ +1.02 kB
index.pack gzip	103 kB	104 kB	⚠️ +260 B
Overall change	1.65 MB	1.65 MB	⚠️ +1.28 kB

Commit: bea1f9b

ForsakenHarmony · 2024-02-16T15:36:31Z

This is missing the lockfile

sokra · 2024-02-16T15:55:15Z

test/turbopack-tests-manifest.json

@@ -1298,7 +1297,7 @@
      "ReactRefreshLogBox default unterminated JSX",
      "ReactRefreshLogBox turbo internal package errors"
    ],
-    "flakey": ["ReactRefreshLogBox turbo conversion to class component (1)"],


You need to update the build-turbopack-manifest for this

Update to turbopack-240215.5

0502dc1

Includes: - vercel/turborepo#7401 This makes “conversion to class component” Turbopack tests pass.

wbinnssmith requested review from timneutkens, ijjk, shuding, huozhi, a team, feedthejim, ztanner and wyattjoh as code owners February 15, 2024 21:32

ijjk added area: tests created-by: Turbopack team PRs by the Turbopack team. type: next labels Feb 15, 2024

wbinnssmith requested review from kwonoj and sokra February 15, 2024 21:32

fixup! Update to turbopack-240215.5

e4301b7

kwonoj approved these changes Feb 15, 2024

View reviewed changes

wbinnssmith enabled auto-merge (squash) February 15, 2024 23:27

fixup! Update to turbopack-240215.5

bea1f9b

wbinnssmith merged commit 60b6068 into canary Feb 16, 2024
71 checks passed

wbinnssmith deleted the wbinnssmith/turbopack-240215.5 branch February 16, 2024 00:52

sokra reviewed Feb 16, 2024

View reviewed changes

github-actions bot added the locked label Mar 2, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to `turbopack-240215.5` #62119

Update to `turbopack-240215.5` #62119

wbinnssmith commented Feb 15, 2024

ijjk commented Feb 15, 2024 •

edited

Loading

ijjk commented Feb 15, 2024 •

edited

Loading

ForsakenHarmony commented Feb 16, 2024

sokra Feb 16, 2024

Update to turbopack-240215.5 #62119

Update to turbopack-240215.5 #62119

Conversation

wbinnssmith commented Feb 15, 2024

ijjk commented Feb 15, 2024 • edited Loading

Failing test suites

ijjk commented Feb 15, 2024 • edited Loading

Stats from current PR

ForsakenHarmony commented Feb 16, 2024

sokra Feb 16, 2024

Choose a reason for hiding this comment

Update to `turbopack-240215.5` #62119

Update to `turbopack-240215.5` #62119

ijjk commented Feb 15, 2024 •

edited

Loading

ijjk commented Feb 15, 2024 •

edited

Loading