Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix draft mode invariant #62121

Merged
merged 13 commits into from
Feb 21, 2024
Merged

Fix draft mode invariant #62121

Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0ea9a01
remove `__nextDataReq=1`
Ethan-Arrowood Feb 15, 2024
a009b26
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 15, 2024
0ae08fc
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 15, 2024
8853752
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 16, 2024
0610963
update base-server
Ethan-Arrowood Feb 16, 2024
2b24b51
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 19, 2024
dfe2b5b
Update packages/next/src/server/base-server.ts
Ethan-Arrowood Feb 19, 2024
665e5fa
prettier
Ethan-Arrowood Feb 19, 2024
537ce84
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 20, 2024
02da911
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 20, 2024
b8baba9
Update packages/next/src/server/base-server.ts
Ethan-Arrowood Feb 21, 2024
7042b15
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 21, 2024
5513684
Merge branch 'canary' into fix/draft-mode-invariant
Ethan-Arrowood Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/src/server/base-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2831,7 +2831,7 @@ export default abstract class Server<ServerOptions extends Options = Options> {
res.setHeader(NEXT_DID_POSTPONE_HEADER, '1')
}

if (isDataReq) {
if (isDataReq && !isPreviewMode) {
Ethan-Arrowood marked this conversation as resolved.
Show resolved Hide resolved
// If this is a dynamic RSC request, then stream the response.
if (isDynamicRSCRequest) {
if (cachedData.pageData) {
Expand Down