-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vendored react versions #62302
Bump vendored react versions #62302
Conversation
Failing test suitesCommit: 58ef5c4
Expand output● Strict Mode enabled by default › should work using browser
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - navigation › query string › useParams identity between renders › should be stable in app
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
buildDuration | 20.5s | 20.4s | N/A |
buildDurationCached | 8.8s | 8.8s | N/A |
nodeModulesSize | 196 MB | 197 MB | |
nextStartRea..uration (ms) | 406ms | 409ms | N/A |
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
1068-HASH.js gzip | 30.3 kB | 30.3 kB | N/A |
3f784ff6-HASH.js gzip | 53.5 kB | 53.7 kB | |
4944-HASH.js gzip | 5.04 kB | 5.03 kB | N/A |
8423.HASH.js gzip | 181 B | 181 B | ✓ |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 241 B | 242 B | N/A |
main-HASH.js gzip | 32.2 kB | 32.1 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 101 kB | 101 kB |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
_app-HASH.js gzip | 196 B | 196 B | ✓ |
_error-HASH.js gzip | 184 B | 183 B | N/A |
amp-HASH.js gzip | 503 B | 504 B | N/A |
css-HASH.js gzip | 323 B | 324 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.51 kB | N/A |
edge-ssr-HASH.js gzip | 258 B | 259 B | N/A |
head-HASH.js gzip | 353 B | 351 B | N/A |
hooks-HASH.js gzip | 370 B | 370 B | ✓ |
image-HASH.js gzip | 4.21 kB | 4.2 kB | N/A |
index-HASH.js gzip | 259 B | 259 B | ✓ |
link-HASH.js gzip | 2.68 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 313 B | 314 B | N/A |
script-HASH.js gzip | 386 B | 385 B | N/A |
withRouter-HASH.js gzip | 309 B | 311 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 931 B | 931 B | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
_buildManifest.js gzip | 485 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
index.html gzip | 529 B | 528 B | N/A |
link.html gzip | 540 B | 541 B | N/A |
withRouter.html gzip | 524 B | 523 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
edge-ssr.js gzip | 94.8 kB | 94.8 kB | N/A |
page.js gzip | 152 kB | 152 kB | |
Overall change | 152 kB | 152 kB |
Middleware size
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 627 B | 626 B | N/A |
middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
middleware.js gzip | 44.9 kB | 44.9 kB | N/A |
edge-runtime..pack.js gzip | 1.94 kB | 1.94 kB | ✓ |
Overall change | 2.1 kB | 2.1 kB | ✓ |
Next Runtimes Overall increase ⚠️
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 167 kB | 170 kB | |
app-page-exp..prod.js gzip | 96.2 kB | 96.5 kB | |
app-page-tur..prod.js gzip | 97.9 kB | 98.3 kB | |
app-page-tur..prod.js gzip | 92.4 kB | 92.8 kB | |
app-page.run...dev.js gzip | 136 kB | 151 kB | |
app-page.run..prod.js gzip | 90.9 kB | 91.3 kB | |
app-route-ex...dev.js gzip | 22.1 kB | 21.9 kB | N/A |
app-route-ex..prod.js gzip | 14.9 kB | 15 kB | N/A |
app-route-tu..prod.js gzip | 14.9 kB | 15 kB | N/A |
app-route-tu..prod.js gzip | 14.7 kB | 14.7 kB | N/A |
app-route.ru...dev.js gzip | 21.8 kB | 21.6 kB | N/A |
app-route.ru..prod.js gzip | 14.7 kB | 14.7 kB | N/A |
pages-api-tu..prod.js gzip | 9.49 kB | 9.49 kB | ✓ |
pages-api.ru...dev.js gzip | 9.76 kB | 9.76 kB | ✓ |
pages-api.ru..prod.js gzip | 9.48 kB | 9.48 kB | ✓ |
pages-turbo...prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
pages.runtim...dev.js gzip | 23 kB | 23 kB | ✓ |
pages.runtim..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
server.runti..prod.js gzip | 50.3 kB | 50.3 kB | ✓ |
Overall change | 827 kB | 846 kB |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js upgrade-react | Change | |
---|---|---|---|
0.pack gzip | 1.55 MB | 1.55 MB | N/A |
index.pack gzip | 104 kB | 104 kB | |
Overall change | 104 kB | 104 kB |
Diff details
Diff for page.js
Diff too large to display
Diff for 1068-HASH.js
Diff too large to display
Diff for 3f784ff6-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js
Diff too large to display
Diff for app-route-ex..ntime.dev.js
Diff too large to display
Diff for app-route-ex..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route.runtime.dev.js
Diff too large to display
Diff for app-route.ru..time.prod.js
Diff too large to display
The tests seem to be passed locally.. |
React upstream changes
yarn flags --sort flag
facebook/react#28344reference
param type inregisterServerReference
facebook/react#27688_debugInfo
from Arrays, Lazy, Thenables and Elements to the inner Fibers. facebook/react#28286yarn flags --sort flag
facebook/react#28344reference
param type inregisterServerReference
facebook/react#27688_debugInfo
from Arrays, Lazy, Thenables and Elements to the inner Fibers. facebook/react#28286Closes NEXT-2542