hotfix(next):next lint installs eslint@9 which includes breaking changes

[devjiwonchoi]

This is a hotfix since it breaks next lint, I'll start to implement eslint v9 for canary.

x-ref: #64114
x-ref: eslint v9 release
Fixes #64136

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 25da86a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 25da86a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Tests Passed

[ijjk]

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
buildDuration	13.9s	13.9s	N/A
buildDurationCached	8.5s	6.3s	N/A
nodeModulesSize	199 MB	199 MB	⚠️ +2.18 kB
nextStartRea..uration (ms)	398ms	400ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
2453-HASH.js gzip	31.4 kB	31.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	241 B	N/A
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99 kB	99 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
index.html gzip	529 B	529 B	✓
link.html gzip	541 B	541 B	✓
withRouter.html gzip	523 B	524 B	N/A
Overall change	1.07 kB	1.07 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
edge-ssr.js gzip	95.4 kB	95.4 kB	N/A
page.js gzip	3.06 kB	3.06 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
middleware-b..fest.js gzip	625 B	624 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
app-page-exp...dev.js gzip	170 kB	170 kB	✓
app-page-exp..prod.js gzip	97 kB	97 kB	✓
app-page-tur..prod.js gzip	98.8 kB	98.8 kB	✓
app-page-tur..prod.js gzip	93 kB	93 kB	✓
app-page.run...dev.js gzip	144 kB	144 kB	✓
app-page.run..prod.js gzip	91.5 kB	91.5 kB	✓
app-route-ex...dev.js gzip	21.4 kB	21.4 kB	✓
app-route-ex..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route.ru...dev.js gzip	21.1 kB	21.1 kB	✓
app-route.ru..prod.js gzip	14.9 kB	14.9 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	22.5 kB	22.5 kB	✓
pages.runtim...dev.js gzip	23.1 kB	23.1 kB	✓
pages.runtim..prod.js gzip	22.4 kB	22.4 kB	✓
server.runti..prod.js gzip	51.1 kB	51.1 kB	✓
Overall change	945 kB	945 kB	✓

build cache

	vercel/next.js canary	devjiwonchoi/next.js eslint-9	Change
0.pack gzip	1.58 MB	1.58 MB	N/A
index.pack gzip	106 kB	106 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for middleware.js

Diff too large to display

Commit: f4b6767

[devjiwonchoi]

hmm, works locally for TURBOPACK=1 pnpm test test/integration/eslint/test/next-lint.test.js

RFC: is it all good for me to start implementing v9 on create-next-app, next lint, eslint-config-next, etc.?

[darthmaim]

RFC: is it all good for me to start implementing v9 on create-next-app, next lint, eslint-config-next, etc.?

You can check #56181 which was a PR that tried to implement support for the new flat config format.

[ztanner]

Thank you for the quick hotfix!

[devjiwonchoi]

Thank you for reviewing, I hope you have a great weekend!

[ztanner]

You as well! We could probably have optimized this a bit more to exit the loop once we find eslint, but probably doesn't matter that much since the missing list is likely fairly small 😆

[devjiwonchoi]

Thanks for your insight. I totally agree that it is a much better practice. Yes, honestly, since the list is limited to lint, the length is short so didn't optimize it. I'll do better next time. Thank you again!

[KieraDOG]

Hey @devjiwonchoi , thanks for your hard work. By the way, do you have an active PR or issue that links to the implementation of ESLint v9? I'd like to have it for tracking purposes.

[devjiwonchoi]

@KieraDOG I'm not working on it since #64251 is opened already!