Update 02-server-actions-and-mutations.mdx #64248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistake in the docs. action should not be apply on the button. only formAction or onClick is allow.
aktoriukas
requested review from
jh3y and
delbaoliveira
and removed request for
a team
|
@aktoriukas Thanks for the catch! Let's use |
adding `onClick` instead of the `formAction` as per `samcx` request. also adding `'use client'` as to use `onClick` component has to be client component.
|
ok @samcx , adding also adding |
@samcx just for curiosity and learning, why did you suggest to use |
AhmedBaset
reviewed
Apr 12, 2024
| @@ -928,11 +929,12 @@ export default function Page() { | |||
| ... | |||
| } | |||
|
|
|||
| return <button action={publish}>Publish</button>; | |||
| return <button onClick={publish}>Publish</button>; | |||
There was a problem hiding this comment.
@samcx
onClick passes MouseEvent param not FormData. formAction was correct
There was a problem hiding this comment.
@A7med3bdulBaset Thanks for the correction, will update!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving Documentation
mistake in the docs.
action should not be apply on the button.
only formAction or onClick is allow.