Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trace] Reduce the size of .next/trace files #65101

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

mknichel
Copy link
Member

@mknichel mknichel commented Apr 26, 2024

  • Remove next-swc-* and read-resource spans since they are high volume and generally very fast
  • Added NEXT_TRACE_SPAN_THRESHOLD_MS env var to only record trace spans that take longer than a threshold.

@ijjk
Copy link
Member

ijjk commented Apr 26, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
buildDuration 18.3s 17.1s N/A
buildDurationCached 9.6s 8.3s N/A
nodeModulesSize 360 MB 360 MB N/A
nextStartRea..uration (ms) 460ms 465ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.09 kB 5.09 kB N/A
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 230 B 229 B N/A
main-HASH.js gzip 31.5 kB 31.5 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4 kB 4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
index.html gzip 526 B 526 B
link.html gzip 540 B 541 B N/A
withRouter.html gzip 523 B 525 B N/A
Overall change 526 B 526 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
edge-ssr.js gzip 94.7 kB 94.7 kB N/A
page.js gzip 181 kB 181 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 995 B 995 B
Next Runtimes
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93.1 kB 93.1 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 962 kB 962 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mknichel/trim-next-trace-spans-20240426 Change
0.pack gzip 1.62 MB 1.62 MB N/A
index.pack gzip 113 kB 114 kB ⚠️ +1.13 kB
Overall change 113 kB 114 kB ⚠️ +1.13 kB
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 7f08b11

@mknichel mknichel changed the title [trace] Remove next-swc-* and read-resource spans to reduce .next/trace size [trace] Reduce the size of .next/trace files Apr 26, 2024
@mknichel mknichel marked this pull request as ready for review April 26, 2024 23:15
@ijjk
Copy link
Member

ijjk commented Apr 30, 2024

Failing test suites

Commit: cfa555f

TURBOPACK=1 pnpm test-start test/e2e/app-dir/actions-allowed-origins/app-action-allowed-origins.test.ts (turbopack)

  • app-dir action allowed origins > should pass if localhost is set as a safe origin
Expand output

● app-dir action allowed origins › should pass if localhost is set as a safe origin

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  252 |   let next: NextInstance | undefined
  253 |   if (!skipped) {
> 254 |     beforeAll(async () => {
      |     ^
  255 |       next = await createNext(options)
  256 |     })
  257 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:254:5)
  at e2e/app-dir/actions-allowed-origins/app-action-allowed-origins.test.ts:6:42
  at Object.describe (e2e/app-dir/actions-allowed-origins/app-action-allowed-origins.test.ts:5:1)

● Test suite failed to run

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  131 |
  132 | if (typeof afterAll === 'function') {
> 133 |   afterAll(async () => {
      |   ^
  134 |     if (nextInstance) {
  135 |       await nextInstance.destroy()
  136 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:133:3)
  at Object.<anonymous> (e2e/app-dir/actions-allowed-origins/app-action-allowed-origins.test.ts:5:19)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test-start test/e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts (turbopack)

  • parallel-routes-and-interception > parallel routes > should gracefully handle when two page segments match the children parallel slot
  • parallel-routes-and-interception > parallel routes > should throw a 404 when no matching parallel route is found
  • parallel-routes-and-interception > parallel routes > should render nested parallel routes
  • parallel-routes-and-interception > parallel routes > should support layout files in parallel routes
  • parallel-routes-and-interception > parallel routes > should only scroll to the parallel route that was navigated to
  • parallel-routes-and-interception > parallel routes > should apply the catch-all route to the parallel route if no matching route is found
  • parallel-routes-and-interception > parallel routes > should match the catch-all routes of the more specific path, if there is more than one catch-all route
  • parallel-routes-and-interception > parallel routes > should navigate with a link with prefetch=false
  • parallel-routes-and-interception > parallel routes > should display all parallel route params with useParams
  • parallel-routes-and-interception > parallel routes > should load CSS for a default page that exports another page
  • parallel-routes-and-interception > parallel routes > should handle a loading state
  • parallel-routes-and-interception > route intercepting > should render intercepted route
  • parallel-routes-and-interception > route intercepting > should render an intercepted route from a slot
  • parallel-routes-and-interception > route intercepting > should render an intercepted route at the top level from a nested path
  • parallel-routes-and-interception > route intercepting > should render intercepted route from a nested route
  • parallel-routes-and-interception > route intercepting > should re-render the layout on the server when it had a default child route
  • parallel-routes-and-interception > route intercepting > should render modal when paired with parallel routes
  • parallel-routes-and-interception > route intercepting > should support intercepting with beforeFiles rewrites
  • parallel-routes-and-interception > route intercepting > should support intercepting local dynamic sibling routes
  • parallel-routes-and-interception > route intercepting > should intercept on routes that contain hyphenated/special dynamic params
  • parallel-routes-and-interception > route intercepting > should not have /default paths in the prerender manifest
  • parallel-routes-and-interception > route intercepting with dynamic catch-all routes > should render intercepted route
  • parallel-routes-and-interception > route intercepting with dynamic optional catch-all routes > should render intercepted route
  • parallel-routes-and-interception > route intercepting with dynamic routes > should render intercepted route
Expand output

● parallel-routes-and-interception › parallel routes › should gracefully handle when two page segments match the children parallel slot

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  184 |     })
  185 |
> 186 |     it('should gracefully handle when two page segments match the `children` parallel slot', async () => {
      |     ^
  187 |       await next.stop()
  188 |       await next.patchFile(
  189 |         'app/parallel/nested-2/page.js',

  at it (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:186:5)
  at describe (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:10:3)
  at Object.describe (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:5:1)

● parallel-routes-and-interception › parallel routes › should throw a 404 when no matching parallel route is found

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-tab-bar
Call log:
  - navigating to "http://localhost:35549/parallel-tab-bar", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:218:23)

● parallel-routes-and-interception › parallel routes › should render nested parallel routes

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-side-bar/nested/deeper
Call log:
  - navigating to "http://localhost:35549/parallel-side-bar/nested/deeper", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:237:23)

● parallel-routes-and-interception › parallel routes › should support layout files in parallel routes

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-layout
Call log:
  - navigating to "http://localhost:35549/parallel-layout", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:271:23)

● parallel-routes-and-interception › parallel routes › should only scroll to the parallel route that was navigated to

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-scroll
Call log:
  - navigating to "http://localhost:35549/parallel-scroll", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:290:23)

● parallel-routes-and-interception › parallel routes › should apply the catch-all route to the parallel route if no matching route is found

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-catchall
Call log:
  - navigating to "http://localhost:35549/parallel-catchall", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:302:23)

● parallel-routes-and-interception › parallel routes › should match the catch-all routes of the more specific path, if there is more than one catch-all route

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-nested-catchall
Call log:
  - navigating to "http://localhost:35549/parallel-nested-catchall", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:334:23)

● parallel-routes-and-interception › parallel routes › should navigate with a link with prefetch=false

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-prefetch-false
Call log:
  - navigating to "http://localhost:35549/parallel-prefetch-false", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:365:23)

● parallel-routes-and-interception › parallel routes › should display all parallel route params with useParams

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-dynamic/foo/bar
Call log:
  - navigating to "http://localhost:35549/parallel-dynamic/foo/bar", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:386:23)

● parallel-routes-and-interception › parallel routes › should load CSS for a default page that exports another page

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/default-css
Call log:
  - navigating to "http://localhost:35549/default-css", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:400:23)

● parallel-routes-and-interception › parallel routes › should handle a loading state

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/with-loading
Call log:
  - navigating to "http://localhost:35549/with-loading", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:428:23)

● parallel-routes-and-interception › route intercepting with dynamic routes › should render intercepted route

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/intercepting-routes-dynamic/photos
Call log:
  - navigating to "http://localhost:35549/intercepting-routes-dynamic/photos", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:485:23)

● parallel-routes-and-interception › route intercepting with dynamic optional catch-all routes › should render intercepted route

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/intercepting-routes-dynamic-catchall/photos
Call log:
  - navigating to "http://localhost:35549/intercepting-routes-dynamic-catchall/photos", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:523:23)

● parallel-routes-and-interception › route intercepting with dynamic catch-all routes › should render intercepted route

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/intercepting-routes-dynamic-catchall/photos
Call log:
  - navigating to "http://localhost:35549/intercepting-routes-dynamic-catchall/photos", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:568:23)

● parallel-routes-and-interception › route intercepting › should render intercepted route

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/intercepting-routes/feed
Call log:
  - navigating to "http://localhost:35549/intercepting-routes/feed", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:611:23)

● parallel-routes-and-interception › route intercepting › should render an intercepted route from a slot

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/
Call log:
  - navigating to "http://localhost:35549/", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:648:23)

● parallel-routes-and-interception › route intercepting › should render an intercepted route at the top level from a nested path

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/nested-link
Call log:
  - navigating to "http://localhost:35549/nested-link", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:678:23)

● parallel-routes-and-interception › route intercepting › should render intercepted route from a nested route

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/intercepting-routes/feed/nested
Call log:
  - navigating to "http://localhost:35549/intercepting-routes/feed/nested", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:702:23)

● parallel-routes-and-interception › route intercepting › should re-render the layout on the server when it had a default child route

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/parallel-non-intercepting
Call log:
  - navigating to "http://localhost:35549/parallel-non-intercepting", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:739:23)

● parallel-routes-and-interception › route intercepting › should render modal when paired with parallel routes

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/intercepting-parallel-modal/vercel
Call log:
  - navigating to "http://localhost:35549/intercepting-parallel-modal/vercel", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:763:23)

● parallel-routes-and-interception › route intercepting › should support intercepting with beforeFiles rewrites

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/foo
Call log:
  - navigating to "http://localhost:35549/foo", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:811:23)

● parallel-routes-and-interception › route intercepting › should support intercepting local dynamic sibling routes

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/intercepting-siblings
Call log:
  - navigating to "http://localhost:35549/intercepting-siblings", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:825:23)

● parallel-routes-and-interception › route intercepting › should intercept on routes that contain hyphenated/special dynamic params

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:35549/interception-route-special-params/some-random-param
Call log:
  - navigating to "http://localhost:35549/interception-route-special-params/some-random-param", waiting until "load"

  274 |     opts?.beforePageLoad?.(page)
  275 |
> 276 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  277 |   }
  278 |
  279 |   back(options): BrowserInterface {

  at BrowserInterface.goto (lib/browsers/playwright.ts:276:16)
  at webdriver (lib/next-webdriver.ts:129:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:861:23)

● parallel-routes-and-interception › route intercepting › should not have /default paths in the prerender manifest

ENOENT: no such file or directory, open '/tmp/next-install-599f2b5d04b17bf004bba8160add546a5aefdb75183d7f6baa7fa211147b567f/.next/prerender-manifest.json'

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens enabled auto-merge (squash) April 30, 2024 15:47
@timneutkens timneutkens merged commit 2c0aeee into canary Apr 30, 2024
78 of 80 checks passed
@timneutkens timneutkens deleted the mknichel/trim-next-trace-spans-20240426 branch April 30, 2024 16:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants