Extract slow tests to avoid wasteful start/stop #65265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extracted test started timing out in #65058. When it does, it leaves the whole test suite in a corrupted state and fails all subsequent tests.
The slow part was just immediately stopping. It also wasn't robust against test failures since the cleanup logic was in the test itself not
beforeEach
orafterEach
.I moved the test to a separate describe block where tests don't start with a started Next.js server. This saves time and isolates failing tests.
Closes NEXT-3280