Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revalidateTag to batch tags in one request #65296

Merged
merged 6 commits into from
May 3, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 2, 2024

As discussed this collects all revalidateTag calls and invokes in a single request to avoid race conditions and overhead from multiple pending requests.

x-ref: slack thread

Closes NEXT-3306

@ijjk
Copy link
Member Author

ijjk commented May 2, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
buildDuration 27s 24.7s N/A
buildDurationCached 13.9s 11.2s N/A
nodeModulesSize 360 MB 360 MB ⚠️ +35.9 kB
nextStartRea..uration (ms) 757ms 760ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.05 kB 5.05 kB
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 231 B 228 B N/A
main-HASH.js gzip 31.6 kB 31.6 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 50.4 kB 50.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.27 kB 4.27 kB
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 8.27 kB 8.27 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
index.html gzip 527 B 528 B N/A
link.html gzip 540 B 540 B
withRouter.html gzip 522 B 524 B N/A
Overall change 540 B 540 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
edge-ssr.js gzip 94.7 kB 94.8 kB N/A
page.js gzip 182 kB 182 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
middleware-b..fest.js gzip 624 B 624 B
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.62 kB 1.62 kB
Next Runtimes
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
app-page-exp...dev.js gzip 171 kB 171 kB N/A
app-page-exp..prod.js gzip 98.7 kB 98.8 kB N/A
app-page-tur..prod.js gzip 100 kB 100 kB N/A
app-page-tur..prod.js gzip 94.5 kB 94.6 kB N/A
app-page.run...dev.js gzip 157 kB 157 kB N/A
app-page.run..prod.js gzip 93.2 kB 93.3 kB N/A
app-route-ex...dev.js gzip 21.5 kB 21.5 kB N/A
app-route-ex..prod.js gzip 15.2 kB 15.3 kB N/A
app-route-tu..prod.js gzip 15.2 kB 15.3 kB N/A
app-route-tu..prod.js gzip 15 kB 15 kB N/A
app-route.ru...dev.js gzip 21.3 kB 21.3 kB N/A
app-route.ru..prod.js gzip 15 kB 15 kB N/A
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.6 kB 51.7 kB N/A
Overall change 94 kB 94 kB
build cache Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/batch-revalidate-tags Change
0.pack gzip 1.62 MB 1.62 MB N/A
index.pack gzip 113 kB 114 kB ⚠️ +510 B
Overall change 113 kB 114 kB ⚠️ +510 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: b53763f

@ijjk ijjk requested a review from ztanner May 2, 2024 22:49
@ijjk ijjk merged commit 025f5b6 into vercel:canary May 3, 2024
74 checks passed
@ijjk ijjk deleted the update/batch-revalidate-tags branch May 3, 2024 02:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants