Try restarting chromedriver on timeout #6566

ijjk · 2019-03-07T20:09:58Z

Also added HEADLESS env var for local testing

flag for local testing

github-actions · 2019-03-07T20:13:20Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	16s	17s	⚠️ +5.83%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	145 MB	145 MB	-0.27%
Max Memory Usage	209 MB	209 MB	-0.07%
Average CPU Usage	95.91%	95.83%	-0.08%
Max CPU Usage	111.11%	111.11%	✓
`node_modules` Size	42.9 MB	42.9 MB	✓

github-actions · 2019-03-07T20:13:42Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	16.3s	16.5s	⚠️ +0.83%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	147 MB	147 MB	⚠️ +0.26%
Max Memory Usage	208 MB	208 MB	-0.12%
Average CPU Usage	95.29%	96.06%	⚠️ +0.81%
Max CPU Usage	122.22%	111.11%	-9.09%
`node_modules` Size	42.9 MB	42.9 MB	✓

retry to only retry max twice

…s-ci-test

github-actions · 2019-03-07T20:45:17Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	15.7s	15.5s	-0.84%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	145 MB	147 MB	⚠️ +1.84%
Max Memory Usage	210 MB	208 MB	-0.69%
Average CPU Usage	93.24%	96%	⚠️ +2.96%
Max CPU Usage	122.22%	111.11%	-9.09%
`node_modules` Size	42.9 MB	42.9 MB	✓

github-actions · 2019-03-07T21:25:20Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	16.3s	16.5s	⚠️ +1.02%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	147 MB	142 MB	-3.5%
Max Memory Usage	208 MB	176 MB	-15.29%
Average CPU Usage	94.74%	93.67%	-1.13%
Max CPU Usage	111.11%	111.11%	✓
`node_modules` Size	42.9 MB	42.9 MB	✓

github-actions · 2019-03-07T21:57:20Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	16.8s	16.7s	-0.87%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	142 MB	143 MB	⚠️ +0.89%
Max Memory Usage	177 MB	176 MB	-0.14%
Average CPU Usage	97.84%	98.05%	⚠️ +0.21%
Max CPU Usage	111.11%	111.11%	✓
`node_modules` Size	42.9 MB	42.9 MB	✓

Janpot · 2019-03-07T22:06:33Z

test/lib/next-webdriver.js

+        driverPort = await getPort()
+        chromedriver.stop()
+        chromedriver.start([`--port=${driverPort}`])
+        // https://github.com/giggio/node-chromedriver/issues/117


Looking at giggio/node-chromedriver#177 It seems like when you call it like

await chromedriver.start([`--port=${driverPort}`], true)

You can eliminate the wait-port dependency. Since you updated chromedriver, this PR should be included in the new version now.

That's true, although it looks like the timeout is fixed that way and unfortunately I think we need to allow the timeout to be higher than 10 seconds. Thanks for looking

ok, I filed giggio/node-chromedriver#193

test to make windows happy

github-actions · 2019-03-07T22:39:15Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	16.1s	15.5s	-3.16%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	147 MB	147 MB	⚠️ +0.18%
Max Memory Usage	207 MB	207 MB	-0.16%
Average CPU Usage	95.69%	96%	⚠️ +0.32%
Max CPU Usage	110%	111.11%	⚠️ +1.01%
`node_modules` Size	42.9 MB	42.9 MB	✓

github-actions · 2019-03-07T23:09:13Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	16.1s	16.3s	⚠️ +1.21%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.76 kB	-0.01%
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	148 MB	147 MB	-0.74%
Max Memory Usage	209 MB	208 MB	-0.39%
Average CPU Usage	95.82%	95.79%	-0.03%
Max CPU Usage	111.11%	111.11%	✓
`node_modules` Size	42.9 MB	42.9 MB	✓

github-actions · 2019-03-08T01:04:47Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	17.7s	18s	⚠️ +1.73%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	148 MB	146 MB	-1.78%
Max Memory Usage	210 MB	208 MB	-0.9%
Average CPU Usage	94.36%	92.9%	-1.55%
Max CPU Usage	122.22%	110%	-10%
`node_modules` Size	42.9 MB	42.9 MB	✓

github-actions · 2019-03-08T01:29:21Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js windows-ci-test	Change
Build Duration	16.7s	16.6s	-0.83%
Client `_app` Size	2.67 kB	2.67 kB	✓
Client `_app` gzip Size	1.12 kB	1.12 kB	✓
Client `_error` Size	6.56 kB	6.56 kB	✓
Client `_error` gzip Size	2.77 kB	2.77 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `main` Size	20.2 kB	20.2 kB	✓
Client `main` gzip Size	6.77 kB	6.77 kB	✓
Client `commons` Size	190 kB	190 kB	✓
Client `commons` gzip Size	61.2 kB	61.2 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.2 kB	1.2 kB	✓
Build Dir Size	385 kB	385 kB	✓
Average Memory Usage	147 MB	147 MB	⚠️ +0.13%
Max Memory Usage	207 MB	207 MB	⚠️ +0.15%
Average CPU Usage	95.33%	95.94%	⚠️ +0.64%
Max CPU Usage	111.11%	111.11%	✓
`node_modules` Size	42.9 MB	42.9 MB	✓

oliviertassinari · 2019-03-08T09:18:41Z

https://twitter.com/timneutkens/status/1103759973711003649

@ijjk To mitigate the github-actions comment noise, you might be interested in having a look at the React danger solution or mui/material-ui#14587.

ijjk and others added 2 commits March 7, 2019 14:08

Try restarting chromedriver on timeout and add HEADLESS env

ddac666

flag for local testing

Merge branch 'canary' into windows-ci-test

b30ea7d

ijjk added 2 commits March 7, 2019 14:41

Move timeout for with-router test and update chromedriver

50ea2e7

retry to only retry max twice

Merge branch 'windows-ci-test' of github.com:ijjk/next.js into window…

7f83d02

…s-ci-test

Try restarting with random port after failing to connect to chromedriver

a1f7fa6

Try bumping chromedriver version

abcbe03

Janpot reviewed Mar 7, 2019

View reviewed changes

Try increasing the timeout on recursive-readdir

bf40aa7

test to make windows happy

Add git clean before attempting testing again

91321dd

Try making headless mode the default

ca9cb0a

Update travis to not use headless mode

aaafd6f

timneutkens approved these changes Mar 8, 2019

View reviewed changes

timneutkens merged commit a3356c5 into vercel:canary Mar 8, 2019

ijjk deleted the windows-ci-test branch March 8, 2019 16:00

maxheld83 mentioned this pull request May 2, 2019

action to report performance stats maxheld83/ghactions#113

Open

lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020

Try restarting chromedriver on timeout #6566

Try restarting chromedriver on timeout #6566

Conversation

ijjk commented Mar 7, 2019

Uh oh!

github-actions bot commented Mar 7, 2019

Stats from current PR

Uh oh!

github-actions bot commented Mar 7, 2019

Stats from current PR

Uh oh!

github-actions bot commented Mar 7, 2019

Stats from current PR

Uh oh!

github-actions bot commented Mar 7, 2019

Stats from current PR

Uh oh!

github-actions bot commented Mar 7, 2019

Stats from current PR

Uh oh!

Janpot Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ijjk Mar 8, 2019

Choose a reason for hiding this comment

Uh oh!

Janpot Mar 8, 2019

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 7, 2019

Stats from current PR

Uh oh!

github-actions bot commented Mar 7, 2019

Stats from current PR

Uh oh!

github-actions bot commented Mar 8, 2019

Stats from current PR

Uh oh!

github-actions bot commented Mar 8, 2019

Stats from current PR

Uh oh!

oliviertassinari commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Janpot Mar 7, 2019 •

edited

Loading

oliviertassinari commented Mar 8, 2019 •

edited

Loading