Skip to content

Don’t prefetch outside of production #6578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timneutkens merged 3 commits into from
Mar 8, 2019
Merged

Don’t prefetch outside of production #6578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eaa55f
Don’t prefetch outside of production
timneutkens Mar 8, 2019
e83f554
Upate router unit test
ijjk Mar 8, 2019
4d88b8b
Merge branch 'canary' into fix/dont-prefetch-test
ijjk Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next-server/lib/router/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ export default class Router {
async prefetch (url) {
// We don't add support for prefetch in the development mode.
// If we do that, our on-demand-entries optimization won't performs better
if (process.env.NODE_ENV === 'development') return
if (process.env.NODE_ENV !== 'production') return

const { pathname } = parse(url)
const route = toRoute(pathname)
Expand Down
1 change: 1 addition & 0 deletions test/unit/router.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-env jest */
import Router from 'next-server/dist/lib/router/router'
process.env.NODE_ENV = 'production'

class PageLoader {
constructor (options = {}) {
Expand Down