Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't fail the build if @types/ packages appear to be missing" #66130

Merged
merged 1 commit into from
May 23, 2024

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 23, 2024

This reverts commit 637033c.

What wasn't clear originally is that we require that required packages have their package.json resolvable. So either they don't have an exports field, or their package.json is listed in the exports field. The React beta types didn't have package.json entry in exports so we accidentally thought they weren't installed.

I published 19.0.0-beta.2 that has package.json in exports so we can restore the old behavior. It's still questionable IMO to do all that I/O work just for a nicer error message that may contain false-positive but that's for another time.

@ijjk
Copy link
Member

ijjk commented May 23, 2024

Failing test suites

Commit: 6d7a648

TURBOPACK=1 pnpm test-start test/e2e/app-dir/app-static/app-static-custom-handler.test.ts (turbopack)

  • app-dir static/dynamic handling > should have deterministic etag across revalidates
Expand output

● app-dir static/dynamic handling › should have deterministic etag across revalidates

Failing test passed even though it was supposed to fail. Remove `.failing` to remove error.

  621 |
  622 |   if (isNextStart) {
> 623 |     it.failing(
      |        ^
  624 |       'should have deterministic etag across revalidates',
  625 |       async () => {
  626 |         const initialRes = await next.fetch(

  at failing (e2e/app-dir/app-static/app-static.test.ts:623:8)
  at Object.describe (e2e/app-dir/app-static/app-static.test.ts:17:1)
  at Object.require (e2e/app-dir/app-static/app-static-custom-handler.test.ts:2:1)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit 41a8053 into canary May 23, 2024
75 of 77 checks passed
@ijjk ijjk deleted the sebbie/restore-types branch May 23, 2024 14:01
@github-actions github-actions bot added the locked label Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants