Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app-router prefetch crash when an invalid URL is passed to Link #66755
fix: app-router prefetch crash when an invalid URL is passed to Link #66755
Changes from all commits
1c600da
52b4d34
8e75fd3
933f6c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in app router,
router.prefetch
is sync, so this does not return a promise, and the.catch()
below does nothing -- we never reach it. looks like this part was missed whenrouter.prefetch
was changed from sync to async here: f4a01b4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to change this later (for v15) and make
router.prefetch
not throw for invalid URLs -- arguably, prefetches shouldn't blow anything up even if they failed. But this matches existing behavior, and this PR is intended to go into the v14.2 backport branch, so i feel like we may want to preserve what was there for now.Unchanged files with check annotations Beta
Check warning on line 886 in packages/next-swc/crates/napi/src/next_api/project.rs
Check warning on line 886 in packages/next-swc/crates/napi/src/next_api/project.rs
Check warning on line 886 in packages/next-swc/crates/napi/src/next_api/project.rs
Check warning on line 886 in packages/next-swc/crates/napi/src/next_api/project.rs