Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated layout-component with new feature layout.js #67447

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Updated layout-component with new feature layout.js #67447

merged 4 commits into from
Jul 11, 2024

Conversation

archanaagivale30
Copy link
Contributor

Hello

This PR updates the layout-component example to use:

  • App Router
  • layout.js
  • Removed customer implementation of layout in _app.js file.

@ijjk ijjk added the examples Issue/PR related to examples label Jul 4, 2024
@ijjk
Copy link
Member

ijjk commented Jul 4, 2024 •
edited by samcx
Loading

Allow CI Workflow Run

  • approve CI run for commit: eabd29d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@archanaagivale30
Copy link
Contributor Author

cc @samcx

@samcx samcx added CI approved Approve running CI for fork and removed CI approved Approve running CI for fork labels Jul 11, 2024
@samcx samcx self-requested a review July 11, 2024 10:05
samcx
samcx approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) July 11, 2024 10:05
@samcx samcx merged commit 00ed837 into vercel:canary Jul 11, 2024
34 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samcx samcx samcx approved these changes

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archanaagivale30 @ijjk @samcx