-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable development logging by setting logging: false
in next config
#67590
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
da86c73
feat: disable route logging
devjiwonchoi 6929d90
test: disable logging
devjiwonchoi 73a4e65
fix: if logging set to true, allow verbose
devjiwonchoi cddd33c
docs: add logging false
devjiwonchoi 0620b37
Merge branch 'canary' of github.com:vercel/next.js into jwn/3kzd
devjiwonchoi ecb03a9
refactor: don't log on logging false
devjiwonchoi c591bc8
refactor: make fetch object value an obj
devjiwonchoi 70436b5
docs: logging false
devjiwonchoi 25f5872
drill down logging
devjiwonchoi 10a82a0
delete fetchmetrics earlier
devjiwonchoi 20e692f
pass logging
devjiwonchoi 4c7cf6d
refactor: handle boolean value of loggin
devjiwonchoi d2d252f
chore: remove unnecessary early return
devjiwonchoi 79e11b5
do not pass to build store
devjiwonchoi 26ffd56
refactor: don't return handler
devjiwonchoi 5f5d919
refactor
devjiwonchoi 9d48929
Merge branch 'canary' into jwn/3kzd
devjiwonchoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
test/development/app-dir/disable-logging-route/app/[id]/page.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export default function Page({ params: { id } }) { | ||
return <p>{id}</p> | ||
} |
8 changes: 8 additions & 0 deletions
8
test/development/app-dir/disable-logging-route/app/layout.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { ReactNode } from 'react' | ||
export default function Root({ children }: { children: ReactNode }) { | ||
return ( | ||
<html> | ||
<body>{children}</body> | ||
</html> | ||
) | ||
} |
27 changes: 27 additions & 0 deletions
27
test/development/app-dir/disable-logging-route/disable-logging-route.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import { nextTestSetup } from 'e2e-utils' | ||
import { check } from 'next-test-utils' | ||
|
||
describe('disable-logging-route', () => { | ||
const { next } = nextTestSetup({ | ||
files: __dirname, | ||
}) | ||
|
||
it('should not log if disabled logging', async () => { | ||
const html = await next.render('/slug1') | ||
expect(html).toContain('slug1') | ||
expect(next.cliOutput).not.toContain('GET /slug1') | ||
|
||
// re-enable logging | ||
await next.patchFile('next.config.js', (content) => | ||
content.replace('logging: false,', '') | ||
) | ||
|
||
// should log now | ||
await check(async () => { | ||
const html = await next.render('/slug1') | ||
expect(html).toContain('slug1') | ||
expect(next.cliOutput).toContain('GET /slug1') | ||
return 'success' | ||
}, 'success') | ||
}) | ||
}) |
8 changes: 8 additions & 0 deletions
8
test/development/app-dir/disable-logging-route/next.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/** | ||
* @type {import('next').NextConfig} | ||
*/ | ||
const nextConfig = { | ||
logging: false, | ||
} | ||
|
||
module.exports = nextConfig |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the normalize seems not useful here anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I should explicitly use
true
andfalse
for better readability.