Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add important info around global styles #67778

Merged
merged 5 commits into from
Jul 17, 2024
Merged

docs: add important info around global styles #67778

merged 5 commits into from
Jul 17, 2024

Conversation

samcx
Copy link
Member

@samcx samcx commented Jul 15, 2024 •
edited
Loading

Why?

  • We currently don't document why we don't remove styles on navigation. This was true with Pages Router, but it wasn't necessarily an issue folks reported on because we reinforced global css to only be available in _app.js. With App Router, we need to be explicit as to why this is the case.
  • We currently don't recommend turning off sort-imports from linters/formatters since CSS import order matters.

x-ref: #58597 (comment), #58597

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels Jul 15, 2024
@samcx Graphite App
Copy link
Member Author

samcx commented Jul 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @samcx and the rest of your teammates on Graphite Graphite

@samcx samcx requested a review from delbaoliveira July 15, 2024 14:04
@samcx samcx changed the title docs(css): update css docs docs: add important info around global styles Jul 15, 2024
@samcx samcx marked this pull request as ready for review July 15, 2024 14:05
@samcx samcx force-pushed the sam/docs/global-css branch from 3090ae7 to 8a764a1 Compare July 15, 2024 20:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

All broken links are now fixed, thank you!

@samcx @delbaoliveira
docs(css): add delba's feedback :delba_goat:
0742f0b 
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@samcx samcx enabled auto-merge (squash) July 17, 2024 11:33
@samcx samcx merged commit 01cdb26 into canary Jul 17, 2024
50 checks passed
@samcx samcx deleted the sam/docs/global-css branch July 17, 2024 11:35
@github-actions github-actions bot added the locked label Aug 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delbaoliveira delbaoliveira delbaoliveira approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samcx @delbaoliveira @ijjk