Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop react-dev-overlay from production bundle #68197

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Drop react-dev-overlay from production bundle #68197

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
188f4ae
fix: Follow the same require pattern for react-dev-overlay used in ot…
icyJoseph Jul 26, 2024
f125e71
Merge branch 'canary' into fix/react-dev-overlay-included-in-prod-bundle
icyJoseph Jul 29, 2024
1a4ca19
Merge branch 'canary' into fix/react-dev-overlay-included-in-prod-bundle
icyJoseph Jul 29, 2024
dbe31f9
Merge branch 'canary' into fix/react-dev-overlay-included-in-prod-bundle
icyJoseph Jul 29, 2024
0ac2aa0
Merge branch 'canary' into fix/react-dev-overlay-included-in-prod-bundle
icyJoseph Jul 30, 2024
17c569e
Merge branch 'canary' into fix/react-dev-overlay-included-in-prod-bundle
icyJoseph Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/next/src/client/components/router-reducer/fetch-server-response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
import { callServer } from '../../app-call-server'
import { PrefetchKind } from './router-reducer-types'
import { hexHash } from '../../../shared/lib/hash'
import { waitForWebpackRuntimeHotUpdate } from '../react-dev-overlay/app/hot-reloader-client'

export interface FetchServerResponseOptions {
readonly flightRouterState: FlightRouterState
Expand Down Expand Up @@ -191,7 +190,7 @@ export async function fetchServerResponse(
// In dev, the Webpack runtime is minimal for each page.
// We need to ensure the Webpack runtime is updated before executing client-side JS of the new page.
if (process.env.NODE_ENV !== 'production' && !process.env.TURBOPACK) {
await waitForWebpackRuntimeHotUpdate()
await require('../react-dev-overlay/app/hot-reloader-client').waitForWebpackRuntimeHotUpdate()
}

// Handle the `fetch` readable stream that can be unwrapped by `React.use`.
Expand Down
Loading