Compose refactor #68503
Merged
Compose refactor #68503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
hi @leerob, added the link to the documentation to the fact that the "version" attribute results in a warning as you asked, hope this helps |
leerob
reviewed
Aug 15, 2024
examples/with-docker-multi-env/docker/development/docker-compose.yml
Outdated
Show resolved
Hide resolved
examples/with-docker-multi-env/docker/production/docker-compose.yml
Outdated
Show resolved
Hide resolved
examples/with-docker-multi-env/docker/staging/docker-compose.yml
Outdated
Show resolved
Hide resolved
leerob
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
removes 'version' attribute post deprecation from all compose files related to dev, staging and prod env
Why?
For the latest docker compose version i.e docker compose v2, the 'version' attribute has been deprecated, which is currently a warning when you do
docker compose upbut in future would become a requirement. https://github.com/compose-spec/compose-spec/blob/main/spec.md#version-and-name-top-level-elements this mentions that the version has become obsolete for the latest docker compose version.How?
remove the version field in the compose files to remove the warning that one may get during builds
Closes NEXT-