Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the example of api-routes to utilize the App Router #68771

Merged
merged 11 commits into from
Aug 13, 2024

Conversation

Sam-Phillemon9493
Copy link
Contributor

@Sam-Phillemon9493 Sam-Phillemon9493 commented Aug 11, 2024

This PR updates the api-routes example to use the App Router. Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Updated the routing for /, & /person/[id] files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Aug 11, 2024
@ijjk
Copy link
Member

ijjk commented Aug 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: 474d3d8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review August 12, 2024 06:53
@samcx
Copy link
Member

samcx commented Aug 12, 2024

@Sam-Phillemon9493 Let's rename examples/api-routes to examples/route-handlers, since technically we call this Route Handlers with App Router.

@Sam-Phillemon9493
Copy link
Contributor Author

@Sam-Phillemon9493 Let's rename examples/api-routes to examples/route-handlers, since technically we call this Route Handlers with App Router.

@samcx renamed the example.

@samcx samcx self-requested a review August 13, 2024 07:39
@samcx
Copy link
Member

samcx commented Aug 13, 2024

@Sam-Phillemon9493 Make sure to always work with the latest canary, or you may run into issues. Specifically, this change → #68534 caused this to have a merge conflict.

@samcx samcx enabled auto-merge (squash) August 13, 2024 07:46
@samcx samcx merged commit 5ed036d into vercel:canary Aug 13, 2024
37 checks passed
@Sam-Phillemon9493
Copy link
Contributor Author

@Sam-Phillemon9493 Make sure to always work with the latest canary, or you may run into issues. Specifically, this change → #68534 caused this to have a merge conflict.

Thank You, @samcx. Got it, I’ll use the latest canary to avoid issues. Thanks for pointing out the conflict with #68534!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants