Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extensive hydration error test suite for Pages router #70342

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add extensive hydration error test suite for Pages router #70342

merged 2 commits into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. Add extensive hydration error test suite for Pages router 

    Pages router will support both React 18 and 19 which has significant changes for hydration errors.
The existing acceptance tests only cover App router which runs exclusive on React 19.

Ideally this would be a single test suite that just forks on the assertion. However, there are a lot of differences between App router and Pages router and putting that into a single file takes more time.

The goal here is to not regress any further with Pages router when extending support to 18.
Once RC2 landed, I'll merge these test suites.
    @eps1lon
    eps1lon committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f9de607 View commit details
    Browse the repository at this point in the history

  2. Move hydration error link test

    @eps1lon
    eps1lon committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d6b0ab2 View commit details
    Browse the repository at this point in the history