Updated the example of with-styled-jsx-scss to utilize the App Router. #70567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
For the future, please double check these examples are working when testing (test Let's go ahead and remove these Babel |
|
Sure @samcx Will check and update. |
|
@samcx PR is Updated please check. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@styled-jsx/plugin-sass@4.1.1 |
2 tasks
wyattjoh
pushed a commit
that referenced
this pull request
Nov 28, 2024
#70567) This PR updates the with-styled-jsx-scss example for using the App Router. Here are the changes that have been made: - Renamed the "pages" folder to the "app" folder. - Added the layout.tsx file as part of the App Router. - Updated the package.json file. CC: @samcx --------- Co-authored-by: Sam Ko <sam@vercel.com>
samcx
added a commit
that referenced
this pull request
Dec 10, 2024
## Description Follow up [the comment](#70567 (comment)) in #70567. > Let's go ahead and remove these Babel `style-jsx-...` examples. It's getting an error, and it's likely not worth the effort to fix/keep around as an example. In addition, [with-storybook-styled-jsx-scss](https://github.com/vercel/next.js/tree/canary/examples/with-storybook-styled-jsx-scss) example is no longer needed because the common [storybook example](https://github.com/vercel/next.js/tree/canary/examples/with-storybook) exists. ### Adding or Updating Examples - [x] The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - [x] Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md Co-authored-by: Sam Ko <sam@vercel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the with-styled-jsx-scss example for using the App Router.
Here are the changes that have been made:
CC: @samcx