Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the example of with-styled-jsx-scss to utilize the App Router. #70567

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the with-styled-jsx-scss example for using the App Router.
Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Sep 27, 2024
@ijjk
Copy link
Member

ijjk commented Sep 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9908548

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@PapatMayuri PapatMayuri marked this pull request as ready for review October 1, 2024 07:02
@samcx
Copy link
Member

samcx commented Oct 2, 2024

@PapatMayuri

For the future, please double check these examples are working when testing (test next dev, next build, and deploying).

Let's go ahead and remove these Babel style-jsx-... examples. It's getting an error, and it's likely not worth the effort to fix/keep around as an example.

@PapatMayuri
Copy link
Contributor Author

Sure @samcx Will check and update.

@PapatMayuri
Copy link
Contributor Author

@samcx PR is Updated please check.

Copy link

socket-security bot commented Nov 26, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@styled-jsx/plugin-sass@4.1.1

View full report↗︎

@samcx samcx self-requested a review November 26, 2024 22:15
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) November 26, 2024 22:16
@samcx samcx merged commit bdca519 into vercel:canary Nov 26, 2024
39 checks passed
wyattjoh pushed a commit that referenced this pull request Nov 28, 2024
#70567)

This PR updates the with-styled-jsx-scss example for using the App
Router.
Here are the changes that have been made:

- Renamed the "pages" folder to the "app" folder.
- Added the layout.tsx file as part of the App Router.
- Updated the package.json file.

CC: @samcx

---------

Co-authored-by: Sam Ko <sam@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants