avoid accessing performance APIs if fetch is untracked #71164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ztanner
force-pushed
the
10-11-avoid_accessing_performance_apis_if_fetch_is_untracked
branch
from
55e4f2f
to
46eef29
Compare
huozhi
approved these changes
Oct 11, 2024
gnoff
approved these changes
Oct 11, 2024
Tests Passed |
ztanner
deleted the
10-11-avoid_accessing_performance_apis_if_fetch_is_untracked
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a request is marked as internal, we don't record fetch metrics, so we don't need to track a
fetchStart. We're investigating cases whereperformanceAPIs might be unavailable in particular runtimes and can safely exclude internal requests from being subject to the possibility of it not being available.