Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): updated the example of with-styled-jsx to utilize the App Route #71290

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

Sam-Phillemon9493
Copy link
Contributor

This PR updates the with-styled-jsx example to use the App Router. Here are the changes that have been made:

  • Renamed the pages folder to the app folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

The following actions were performed as part of this PR:

  • Ran pnpm prettier-check with no issues found.
  • Executed the pnpm check-examples script.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 15, 2024
@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review October 15, 2024 06:19
@ijjk
Copy link
Member

ijjk commented Oct 15, 2024

Allow CI Workflow Run

  • approve CI run for commit: 240f98c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) October 17, 2024 19:23
@samcx samcx merged commit 4d8442a into vercel:canary Oct 17, 2024
38 checks passed
samcx added a commit that referenced this pull request Oct 18, 2024
…e App Route (#71290)

This PR updates the with-styled-jsx example to use the App Router. Here
are the changes that have been made:

- Renamed the `pages` folder to the `app` folder.
- Added the `layout.tsx` file as part of the App Router.
- Updated the `package.json` file.

The following actions were performed as part of this PR:

- Ran `pnpm prettier-check` with no issues found.
- Executed the `pnpm check-examples` script.

CC: @samcx

---------

Co-authored-by: samcx <sam@vercel.com>
@github-actions github-actions bot added the locked label Nov 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants