[Turbopack] refactor to allow different key value stores #71430

sokra · 2024-10-17T15:03:04Z

What?

refactor BackingStore to allow different KeyValueDatabases, avoid dynamic calls and have ReadTransactions and ValueBuffer as trait associated type.
Also adds a default backing storage to be used by next.js

sokra · 2024-10-17T15:03:16Z

[Turbopack] make snapshot organization more efficient #71466
[Turbopack] refactor to allow different key value stores #71430 👈
[Turbopack] Perf improvement new backend aggregation #71356
[Turbopack] Perf improvements new backend #71249 : 1 other dependent PR (#71414 )
[Turbopack] lmdb Backing Storage performance improvments #71250
[Turbopack] bugfixes in persistent caching #71355
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sokra and the rest of your teammates on Graphite

ijjk · 2024-10-17T15:25:26Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
buildDuration	18s	16.2s	N/A
buildDurationCached	15.3s	13s	N/A
nodeModulesSize	372 MB	372 MB	✓
nextStartRea..uration (ms)	436ms	431ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
4030.HASH.js gzip	169 B	169 B	✓
4eb1dffb-HASH.js gzip	52.6 kB	52.6 kB	N/A
9327-HASH.js gzip	5.27 kB	5.26 kB	N/A
9988-HASH.js gzip	44.3 kB	44.2 kB	N/A
framework-HASH.js gzip	57.4 kB	57.4 kB	✓
main-app-HASH.js gzip	233 B	234 B	N/A
main-HASH.js gzip	32.8 kB	32.8 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	57.5 kB	57.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	192 B	191 B	N/A
amp-HASH.js gzip	510 B	512 B	N/A
css-HASH.js gzip	343 B	343 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	266 B	266 B	✓
head-HASH.js gzip	365 B	365 B	✓
hooks-HASH.js gzip	391 B	392 B	N/A
image-HASH.js gzip	4.4 kB	4.4 kB	N/A
index-HASH.js gzip	266 B	268 B	N/A
link-HASH.js gzip	2.78 kB	2.78 kB	✓
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	396 B	396 B	✓
withRouter-HASH.js gzip	323 B	322 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	4.78 kB	4.78 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
_buildManifest.js gzip	746 B	750 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
index.html gzip	522 B	523 B	N/A
link.html gzip	536 B	537 B	N/A
withRouter.html gzip	519 B	518 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	189 kB	189 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
middleware-b..fest.js gzip	669 B	669 B	✓
middleware-r..fest.js gzip	156 B	156 B	✓
middleware.js gzip	31 kB	31 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	1.67 kB	1.67 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
973-experime...dev.js gzip	322 B	322 B	✓
973.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	314 kB	314 kB	✓
app-page-exp..prod.js gzip	121 kB	121 kB	✓
app-page-tur..prod.js gzip	134 kB	134 kB	✓
app-page-tur..prod.js gzip	129 kB	129 kB	✓
app-page.run...dev.js gzip	305 kB	305 kB	✓
app-page.run..prod.js gzip	116 kB	116 kB	✓
app-route-ex...dev.js gzip	35.6 kB	35.6 kB	✓
app-route-ex..prod.js gzip	24.2 kB	24.2 kB	✓
app-route-tu..prod.js gzip	24.2 kB	24.2 kB	✓
app-route-tu..prod.js gzip	24 kB	24 kB	✓
app-route.ru...dev.js gzip	37.2 kB	37.2 kB	✓
app-route.ru..prod.js gzip	24 kB	24 kB	✓
pages-api-tu..prod.js gzip	9.61 kB	9.61 kB	✓
pages-api.ru...dev.js gzip	11.4 kB	11.4 kB	✓
pages-api.ru..prod.js gzip	9.61 kB	9.61 kB	✓
pages-turbo...prod.js gzip	20.9 kB	20.9 kB	✓
pages.runtim...dev.js gzip	26.5 kB	26.5 kB	✓
pages.runtim..prod.js gzip	20.9 kB	20.9 kB	✓
server.runti..prod.js gzip	60.2 kB	60.2 kB	✓
Overall change	1.45 MB	1.45 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sokra/refactor-different-dbs	Change
0.pack gzip	1.84 MB	1.84 MB	⚠️ +4.69 kB
index.pack gzip	142 kB	143 kB	⚠️ +1.22 kB
Overall change	1.98 MB	1.99 MB	⚠️ +5.92 kB

Diff details

Diff for page.js

@@ -15,7 +15,7 @@
       /***/
     },
 
-    /***/ 7610: /***/ (
+    /***/ 8282: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -30,7 +30,7 @@
         default: () => /* binding */ nHandler,
       });
 
-      // NAMESPACE OBJECT: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/build/webpack/loaders/next-app-loader/index.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsRHgvYz%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
+      // NAMESPACE OBJECT: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/build/webpack/loaders/next-app-loader/index.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsRHgvYz%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
       var page_next_edge_ssr_entry_namespaceObject = {};
       __webpack_require__.r(page_next_edge_ssr_entry_namespaceObject);
       __webpack_require__.d(page_next_edge_ssr_entry_namespaceObject, {
@@ -82,35 +82,35 @@
         workUnitAsyncStorage: () => entry_base /* workUnitAsyncStorage */.Sz,
       });
 
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/web/globals.js
-      var globals = __webpack_require__(9794);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/web/adapter.js + 3 modules
-      var adapter = __webpack_require__(4128);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/build/webpack/loaders/next-edge-ssr-loader/render.js + 85 modules
-      var render = __webpack_require__(1228);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/lib/incremental-cache/index.js + 3 modules
-      var incremental_cache = __webpack_require__(6616);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/app-render/app-render.js + 63 modules
-      var app_render = __webpack_require__(2349);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/route-modules/app-page/module.compiled.js
-      var module_compiled = __webpack_require__(5111);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/route-kind.js
-      var route_kind = __webpack_require__(3223);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/client/components/error-boundary.js
-      var error_boundary = __webpack_require__(7107);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/app-render/entry-base.js + 29 modules
-      var entry_base = __webpack_require__(1150); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/build/webpack/loaders/next-app-loader/index.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsRHgvYz%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/web/globals.js
+      var globals = __webpack_require__(7863);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/web/adapter.js + 3 modules
+      var adapter = __webpack_require__(2926);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/build/webpack/loaders/next-edge-ssr-loader/render.js + 85 modules
+      var render = __webpack_require__(2142);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/lib/incremental-cache/index.js + 3 modules
+      var incremental_cache = __webpack_require__(9399);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/app-render/app-render.js + 63 modules
+      var app_render = __webpack_require__(1747);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/route-modules/app-page/module.compiled.js
+      var module_compiled = __webpack_require__(5372);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/route-kind.js
+      var route_kind = __webpack_require__(5516);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/client/components/error-boundary.js
+      var error_boundary = __webpack_require__(4439);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/app-render/entry-base.js + 29 modules
+      var entry_base = __webpack_require__(9836); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/build/webpack/loaders/next-app-loader/index.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsRHgvYz%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
       const module0 = () =>
         Promise.resolve(/* import() eager */).then(
-          __webpack_require__.bind(__webpack_require__, 2481)
+          __webpack_require__.bind(__webpack_require__, 5886)
         );
       const module1 = () =>
         Promise.resolve(/* import() eager */).then(
-          __webpack_require__.bind(__webpack_require__, 4916)
+          __webpack_require__.bind(__webpack_require__, 1684)
         );
       const page2 = () =>
         Promise.resolve(/* import() eager */).then(
-          __webpack_require__.bind(__webpack_require__, 2266)
+          __webpack_require__.bind(__webpack_require__, 4260)
         );
 
       // We inject the tree and pages here so that we can use them in the route
@@ -173,12 +173,12 @@
       });
 
       //# sourceMappingURL=app-page.js.map
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/lib/page-types.js
-      var page_types = __webpack_require__(8158);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/app-render/encryption-utils.js
-      var encryption_utils = __webpack_require__(5685);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/esm/server/app-render/action-utils.js
-      var action_utils = __webpack_require__(3024); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/dist/build/webpack/loaders/next-edge-ssr-loader/index.js?{"absolute500Path":"","absoluteAppPath":"next/dist/pages/_app","absoluteDocumentPath":"next/dist/pages/_document","absoluteErrorPath":"next/dist/pages/_error","absolutePagePath":"private-next-app-dir/app-edge-ssr/page.js","dev":false,"isServerComponent":true,"page":"/app-edge-ssr/page","stringifiedConfig":"eyJlbnYiOnt9LCJlc2xpbnQiOnsiaWdub3JlRHVyaW5nQnVpbGRzIjpmYWxzZX0sInR5cGVzY3JpcHQiOnsiaWdub3JlQnVpbGRFcnJvcnMiOmZhbHNlLCJ0c2NvbmZpZ1BhdGgiOiJ0c2NvbmZpZy5qc29uIn0sImRpc3REaXIiOiIubmV4dCIsImNsZWFuRGlzdERpciI6dHJ1ZSwiYXNzZXRQcmVmaXgiOiIiLCJjYWNoZU1heE1lbW9yeVNpemUiOjUyNDI4ODAwLCJjb25maWdPcmlnaW4iOiJuZXh0LmNvbmZpZy5qcyIsInVzZUZpbGVTeXN0ZW1QdWJsaWNSb3V0ZXMiOnRydWUsImdlbmVyYXRlRXRhZ3MiOnRydWUsInBhZ2VFeHRlbnNpb25zIjpbInRzeCIsInRzIiwianN4IiwianMiXSwicG93ZXJlZEJ5SGVhZGVyIjp0cnVlLCJjb21wcmVzcyI6dHJ1ZSwiaW1hZ2VzIjp7ImRldmljZVNpemVzIjpbNjQwLDc1MCw4MjgsMTA4MCwxMjAwLDE5MjAsMjA0OCwzODQwXSwiaW1hZ2VTaXplcyI6WzE2LDMyLDQ4LDY0LDk2LDEyOCwyNTYsMzg0XSwicGF0aCI6Ii9fbmV4dC9pbWFnZSIsImxvYWRlciI6ImRlZmF1bHQiLCJsb2FkZXJGaWxlIjoiIiwiZG9tYWlucyI6W10sImRpc2FibGVTdGF0aWNJbWFnZXMiOmZhbHNlLCJtaW5pbXVtQ2FjaGVUVEwiOjYwLCJmb3JtYXRzIjpbImltYWdlL3dlYnAiXSwiZGFuZ2Vyb3VzbHlBbGxvd1NWRyI6ZmFsc2UsImNvbnRlbnRTZWN1cml0eVBvbGljeSI6InNjcmlwdC1zcmMgJ25vbmUnOyBmcmFtZS1zcmMgJ25vbmUnOyBzYW5kYm94OyIsImNvbnRlbnREaXNwb3NpdGlvblR5cGUiOiJhdHRhY2htZW50IiwicmVtb3RlUGF0dGVybnMiOltdLCJ1bm9wdGltaXplZCI6ZmFsc2V9LCJkZXZJbmRpY2F0b3JzIjp7ImFwcElzclN0YXR1cyI6dHJ1ZSwiYnVpbGRBY3Rpdml0eSI6dHJ1ZSwiYnVpbGRBY3Rpdml0eVBvc2l0aW9uIjoiYm90dG9tLXJpZ2h0In0sIm9uRGVtYW5kRW50cmllcyI6eyJtYXhJbmFjdGl2ZUFnZSI6NjAwMDAsInBhZ2VzQnVmZmVyTGVuZ3RoIjo1fSwiYW1wIjp7ImNhbm9uaWNhbEJhc2UiOiIifSwiYmFzZVBhdGgiOiIiLCJzYXNzT3B0aW9ucyI6e30sInRyYWlsaW5nU2xhc2giOmZhbHNlLCJpMThuIjpudWxsLCJwcm9kdWN0aW9uQnJvd3NlclNvdXJjZU1hcHMiOmZhbHNlLCJleGNsdWRlRGVmYXVsdE1vbWVudExvY2FsZXMiOnRydWUsInNlcnZlclJ1bnRpbWVDb25maWciOnt9LCJwdWJsaWNSdW50aW1lQ29uZmlnIjp7fSwicmVhY3RQcm9kdWN0aW9uUHJvZmlsaW5nIjpmYWxzZSwicmVhY3RTdHJpY3RNb2RlIjpudWxsLCJyZWFjdE1heEhlYWRlcnNMZW5ndGgiOjYwMDAsImh0dHBBZ2VudE9wdGlvbnMiOnsia2VlcEFsaXZlIjp0cnVlfSwibG9nZ2luZyI6e30sImV4cGlyZVRpbWUiOjMxNTM2MDAwLCJzdGF0aWNQYWdlR2VuZXJhdGlvblRpbWVvdXQiOjYwLCJtb2R1bGFyaXplSW1wb3J0cyI6eyJAbXVpL2ljb25zLW1hdGVyaWFsIjp7InRyYW5zZm9ybSI6IkBtdWkvaWNvbnMtbWF0ZXJpYWwve3ttZW1iZXJ9fSJ9LCJsb2Rhc2giOnsidHJhbnNmb3JtIjoibG9kYXNoL3t7bWVtYmVyfX0ifX0sIm91dHB1dEZpbGVUcmFjaW5nUm9vdCI6Ii90bXAvbmV4dC1zdGF0c1JIZ3ZZei9zdGF0cy1hcHAiLCJleHBlcmltZW50YWwiOnsiY2FjaGVMaWZlIjp7ImRlZmF1bHQiOnsic3RhbGUiOjMwMCwicmV2YWxpZGF0ZSI6OTAwLCJleHBpcmUiOjQyOTQ5NjcyOTR9LCJzZWNvbmRzIjp7InN0YWxlIjowLCJyZXZhbGlkYXRlIjoxLCJleHBpcmUiOjF9LCJtaW51dGVzIjp7InN0YWxlIjozMDAsInJldmFsaWRhdGUiOjYwLCJleHBpcmUiOjM2MDB9LCJob3VycyI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjozNjAwLCJleHBpcmUiOjg2NDAwfSwiZGF5cyI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjo4NjQwMCwiZXhwaXJlIjo2MDQ4MDB9LCJ3ZWVrcyI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjo2MDQ4MDAsImV4cGlyZSI6MjU5MjAwMH0sIm1heCI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjoyNTkyMDAwLCJleHBpcmUiOjQyOTQ5NjcyOTR9fSwibXVsdGlab25lRHJhZnRNb2RlIjpmYWxzZSwiYXBwTmF2RmFpbEhhbmRsaW5nIjpmYWxzZSwicHJlcmVuZGVyRWFybHlFeGl0Ijp0cnVlLCJzZXJ2ZXJNaW5pZmljYXRpb24iOnRydWUsInNlcnZlclNvdXJjZU1hcHMiOmZhbHNlLCJsaW5rTm9Ub3VjaFN0YXJ0IjpmYWxzZSwiY2FzZVNlbnNpdGl2ZVJvdXRlcyI6ZmFsc2UsInByZWxvYWRFbnRyaWVzT25TdGFydCI6dHJ1ZSwiY2xpZW50Um91dGVyRmlsdGVyIjp0cnVlLCJjbGllbnRSb3V0ZXJGaWx0ZXJSZWRpcmVjdHMiOmZhbHNlLCJmZXRjaENhY2hlS2V5UHJlZml4IjoiIiwibWlkZGxld2FyZVByZWZldGNoIjoiZmxleGlibGUiLCJvcHRpbWlzdGljQ2xpZW50Q2FjaGUiOnRydWUsIm1hbnVhbENsaWVudEJhc2VQYXRoIjpmYWxzZSwiY3B1cyI6MTksIm1lbW9yeUJhc2VkV29ya2Vyc0NvdW50IjpmYWxzZSwiaXNyRmx1c2hUb0Rpc2siOnRydWUsIndvcmtlclRocmVhZHMiOmZhbHNlLCJvcHRpbWl6ZUNzcyI6ZmFsc2UsIm5leHRTY3JpcHRXb3JrZXJzIjpmYWxzZSwic2Nyb2xsUmVzdG9yYXRpb24iOmZhbHNlLCJleHRlcm5hbERpciI6ZmFsc2UsImRpc2FibGVPcHRpbWl6ZWRMb2FkaW5nIjpmYWxzZSwiZ3ppcFNpemUiOnRydWUsImNyYUNvbXBhdCI6ZmFsc2UsImVzbUV4dGVybmFscyI6dHJ1ZSwiZnVsbHlTcGVjaWZpZWQiOmZhbHNlLCJzd2NUcmFjZVByb2ZpbGluZyI6ZmFsc2UsImZvcmNlU3djVHJhbnNmb3JtcyI6ZmFsc2UsImxhcmdlUGFnZURhdGFCeXRlcyI6MTI4MDAwLCJ0dXJibyI6eyJyb290IjoiL3RtcC9uZXh0LXN0YXRzUkhndll6L3N0YXRzLWFwcCJ9LCJ0eXBlZFJvdXRlcyI6ZmFsc2UsInR5cGVkRW52IjpmYWxzZSwicGFyYWxsZWxTZXJ2ZXJDb21waWxlcyI6ZmFsc2UsInBhcmFsbGVsU2VydmVyQnVpbGRUcmFjZXMiOmZhbHNlLCJwcHIiOmZhbHNlLCJ3ZWJwYWNrTWVtb3J5T3B0aW1pemF0aW9ucyI6ZmFsc2UsIm9wdGltaXplU2VydmVyUmVhY3QiOnRydWUsInVzZUVhcmx5SW1wb3J0IjpmYWxzZSwic3RhbGVUaW1lcyI6eyJkeW5hbWljIjowLCJzdGF0aWMiOjMwMH0sImFmdGVyIjpmYWxzZSwic2VydmVyQ29tcG9uZW50c0htckNhY2hlIjp0cnVlLCJzdGF0aWNHZW5lcmF0aW9uTWF4Q29uY3VycmVuY3kiOjgsInN0YXRpY0dlbmVyYXRpb25NaW5QYWdlc1BlcldvcmtlciI6MjUsImR5bmFtaWNJTyI6ZmFsc2UsIm9wdGltaXplUGFja2FnZUltcG9ydHMiOlsibHVjaWRlLXJlYWN0IiwiZGF0ZS1mbnMiLCJsb2Rhc2gtZXMiLCJyYW1kYSIsImFudGQiLCJyZWFjdC1ib290c3RyYXAiLCJhaG9va3MiLCJAYW50LWRlc2lnbi9pY29ucyIsIkBoZWFkbGVzc3VpL3JlYWN0IiwiQGhlYWRsZXNzdWktZmxvYXQvcmVhY3QiLCJAaGVyb2ljb25zL3JlYWN0LzIwL3NvbGlkIiwiQGhlcm9pY29ucy9yZWFjdC8yNC9zb2xpZCIsIkBoZXJvaWNvbnMvcmVhY3QvMjQvb3V0bGluZSIsIkB2aXN4L3Zpc3giLCJAdHJlbW9yL3JlYWN0IiwicnhqcyIsIkBtdWkvbWF0ZXJpYWwiLCJAbXVpL2ljb25zLW1hdGVyaWFsIiwicmVjaGFydHMiLCJyZWFjdC11c2UiLCJlZmZlY3QiLCJAZWZmZWN0L3NjaGVtYSIsIkBlZmZlY3QvcGxhdGZvcm0iLCJAZWZmZWN0L3BsYXRmb3JtLW5vZGUiLCJAZWZmZWN0L3BsYXRmb3JtLWJyb3dzZXIiLCJAZWZmZWN0L3BsYXRmb3JtLWJ1biIsIkBlZmZlY3Qvc3FsIiwiQGVmZmVjdC9zcWwtbXNzcWwiLCJAZWZmZWN0L3NxbC1teXNxbDIiLCJAZWZmZWN0L3NxbC1wZyIsIkBlZmZlY3Qvc3FsLXNxdWxpdGUtbm9kZSIsIkBlZmZlY3Qvc3FsLXNxdWxpdGUtYnVuIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS13YXNtIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS1yZWFjdC1uYXRpdmUiLCJAZWZmZWN0L3JwYyIsIkBlZmZlY3QvcnBjLWh0dHAiLCJAZWZmZWN0L3R5cGVjbGFzcyIsIkBlZmZlY3QvZXhwZXJpbWVudGFsIiwiQGVmZmVjdC9vcGVudGVsZW1ldHJ5IiwiQG1hdGVyaWFsLXVpL2NvcmUiLCJAbWF0ZXJpYWwtdWkvaWNvbnMiLCJAdGFibGVyL2ljb25zLXJlYWN0IiwibXVpLWNvcmUiLCJyZWFjdC1pY29ucy9haSIsInJlYWN0LWljb25zL2JpIiwicmVhY3QtaWNvbnMvYnMiLCJyZWFjdC1pY29ucy9jZyIsInJlYWN0LWljb25zL2NpIiwicmVhY3QtaWNvbnMvZGkiLCJyZWFjdC1pY29ucy9mYSIsInJlYWN0LWljb25zL2ZhNiIsInJlYWN0LWljb25zL2ZjIiwicmVhY3QtaWNvbnMvZmkiLCJyZWFjdC1pY29ucy9naSIsInJlYWN0LWljb25zL2dvIiwicmVhY3QtaWNvbnMvZ3IiLCJyZWFjdC1pY29ucy9oaSIsInJlYWN0LWljb25zL2hpMiIsInJlYWN0LWljb25zL2ltIiwicmVhY3QtaWNvbnMvaW8iLCJyZWFjdC1pY29ucy9pbzUiLCJyZWFjdC1pY29ucy9saWEiLCJyZWFjdC1pY29ucy9saWIiLCJyZWFjdC1pY29ucy9sdSIsInJlYWN0LWljb25zL21kIiwicmVhY3QtaWNvbnMvcGkiLCJyZWFjdC1pY29ucy9yaSIsInJlYWN0LWljb25zL3J4IiwicmVhY3QtaWNvbnMvc2kiLCJyZWFjdC1pY29ucy9zbCIsInJlYWN0LWljb25zL3RiIiwicmVhY3QtaWNvbnMvdGZpIiwicmVhY3QtaWNvbnMvdGkiLCJyZWFjdC1pY29ucy92c2MiLCJyZWFjdC1pY29ucy93aSJdfSwiYnVuZGxlUGFnZXNSb3V0ZXJEZXBlbmRlbmNpZXMiOmZhbHNlLCJjb25maWdGaWxlIjoiL3RtcC9uZXh0LXN0YXRzUkhndll6L3N0YXRzLWFwcC9uZXh0LmNvbmZpZy5qcyIsImNvbmZpZ0ZpbGVOYW1lIjoibmV4dC5jb25maWcuanMifQ==","pagesType":"app","appDirLoader":"bmV4dC1hcHAtbG9hZGVyP25hbWU9YXBwJTJGYXBwLWVkZ2Utc3NyJTJGcGFnZSZwYWdlPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZVBhdGg9cHJpdmF0ZS1uZXh0LWFwcC1kaXIlMkZhcHAtZWRnZS1zc3IlMkZwYWdlLmpzJmFwcERpcj0lMkZ0bXAlMkZuZXh0LXN0YXRzUkhndll6JTJGc3RhdHMtYXBwJTJGYXBwJmFwcFBhdGhzPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZUV4dGVuc2lvbnM9dHN4JnBhZ2VFeHRlbnNpb25zPXRzJnBhZ2VFeHRlbnNpb25zPWpzeCZwYWdlRXh0ZW5zaW9ucz1qcyZiYXNlUGF0aD0mYXNzZXRQcmVmaXg9Jm5leHRDb25maWdPdXRwdXQ9JmZseWluZ1NodXR0bGU9ZmFsc2UmcHJlZmVycmVkUmVnaW9uPSZtaWRkbGV3YXJlQ29uZmlnPWUzMCUzRCE=","sriEnabled":false,"middlewareConfig":"e30="}!
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/lib/page-types.js
+      var page_types = __webpack_require__(1219);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/app-render/encryption-utils.js
+      var encryption_utils = __webpack_require__(6020);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/esm/server/app-render/action-utils.js
+      var action_utils = __webpack_require__(5590); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/dist/build/webpack/loaders/next-edge-ssr-loader/index.js?{"absolute500Path":"","absoluteAppPath":"next/dist/pages/_app","absoluteDocumentPath":"next/dist/pages/_document","absoluteErrorPath":"next/dist/pages/_error","absolutePagePath":"private-next-app-dir/app-edge-ssr/page.js","dev":false,"isServerComponent":true,"page":"/app-edge-ssr/page","stringifiedConfig":"eyJlbnYiOnt9LCJlc2xpbnQiOnsiaWdub3JlRHVyaW5nQnVpbGRzIjpmYWxzZX0sInR5cGVzY3JpcHQiOnsiaWdub3JlQnVpbGRFcnJvcnMiOmZhbHNlLCJ0c2NvbmZpZ1BhdGgiOiJ0c2NvbmZpZy5qc29uIn0sImRpc3REaXIiOiIubmV4dCIsImNsZWFuRGlzdERpciI6dHJ1ZSwiYXNzZXRQcmVmaXgiOiIiLCJjYWNoZU1heE1lbW9yeVNpemUiOjUyNDI4ODAwLCJjb25maWdPcmlnaW4iOiJuZXh0LmNvbmZpZy5qcyIsInVzZUZpbGVTeXN0ZW1QdWJsaWNSb3V0ZXMiOnRydWUsImdlbmVyYXRlRXRhZ3MiOnRydWUsInBhZ2VFeHRlbnNpb25zIjpbInRzeCIsInRzIiwianN4IiwianMiXSwicG93ZXJlZEJ5SGVhZGVyIjp0cnVlLCJjb21wcmVzcyI6dHJ1ZSwiaW1hZ2VzIjp7ImRldmljZVNpemVzIjpbNjQwLDc1MCw4MjgsMTA4MCwxMjAwLDE5MjAsMjA0OCwzODQwXSwiaW1hZ2VTaXplcyI6WzE2LDMyLDQ4LDY0LDk2LDEyOCwyNTYsMzg0XSwicGF0aCI6Ii9fbmV4dC9pbWFnZSIsImxvYWRlciI6ImRlZmF1bHQiLCJsb2FkZXJGaWxlIjoiIiwiZG9tYWlucyI6W10sImRpc2FibGVTdGF0aWNJbWFnZXMiOmZhbHNlLCJtaW5pbXVtQ2FjaGVUVEwiOjYwLCJmb3JtYXRzIjpbImltYWdlL3dlYnAiXSwiZGFuZ2Vyb3VzbHlBbGxvd1NWRyI6ZmFsc2UsImNvbnRlbnRTZWN1cml0eVBvbGljeSI6InNjcmlwdC1zcmMgJ25vbmUnOyBmcmFtZS1zcmMgJ25vbmUnOyBzYW5kYm94OyIsImNvbnRlbnREaXNwb3NpdGlvblR5cGUiOiJhdHRhY2htZW50IiwicmVtb3RlUGF0dGVybnMiOltdLCJ1bm9wdGltaXplZCI6ZmFsc2V9LCJkZXZJbmRpY2F0b3JzIjp7ImFwcElzclN0YXR1cyI6dHJ1ZSwiYnVpbGRBY3Rpdml0eSI6dHJ1ZSwiYnVpbGRBY3Rpdml0eVBvc2l0aW9uIjoiYm90dG9tLXJpZ2h0In0sIm9uRGVtYW5kRW50cmllcyI6eyJtYXhJbmFjdGl2ZUFnZSI6NjAwMDAsInBhZ2VzQnVmZmVyTGVuZ3RoIjo1fSwiYW1wIjp7ImNhbm9uaWNhbEJhc2UiOiIifSwiYmFzZVBhdGgiOiIiLCJzYXNzT3B0aW9ucyI6e30sInRyYWlsaW5nU2xhc2giOmZhbHNlLCJpMThuIjpudWxsLCJwcm9kdWN0aW9uQnJvd3NlclNvdXJjZU1hcHMiOmZhbHNlLCJleGNsdWRlRGVmYXVsdE1vbWVudExvY2FsZXMiOnRydWUsInNlcnZlclJ1bnRpbWVDb25maWciOnt9LCJwdWJsaWNSdW50aW1lQ29uZmlnIjp7fSwicmVhY3RQcm9kdWN0aW9uUHJvZmlsaW5nIjpmYWxzZSwicmVhY3RTdHJpY3RNb2RlIjpudWxsLCJyZWFjdE1heEhlYWRlcnNMZW5ndGgiOjYwMDAsImh0dHBBZ2VudE9wdGlvbnMiOnsia2VlcEFsaXZlIjp0cnVlfSwibG9nZ2luZyI6e30sImV4cGlyZVRpbWUiOjMxNTM2MDAwLCJzdGF0aWNQYWdlR2VuZXJhdGlvblRpbWVvdXQiOjYwLCJtb2R1bGFyaXplSW1wb3J0cyI6eyJAbXVpL2ljb25zLW1hdGVyaWFsIjp7InRyYW5zZm9ybSI6IkBtdWkvaWNvbnMtbWF0ZXJpYWwve3ttZW1iZXJ9fSJ9LCJsb2Rhc2giOnsidHJhbnNmb3JtIjoibG9kYXNoL3t7bWVtYmVyfX0ifX0sIm91dHB1dEZpbGVUcmFjaW5nUm9vdCI6Ii90bXAvbmV4dC1zdGF0c1JIZ3ZZei9zdGF0cy1hcHAiLCJleHBlcmltZW50YWwiOnsiY2FjaGVMaWZlIjp7ImRlZmF1bHQiOnsic3RhbGUiOjMwMCwicmV2YWxpZGF0ZSI6OTAwLCJleHBpcmUiOjQyOTQ5NjcyOTR9LCJzZWNvbmRzIjp7InN0YWxlIjowLCJyZXZhbGlkYXRlIjoxLCJleHBpcmUiOjF9LCJtaW51dGVzIjp7InN0YWxlIjozMDAsInJldmFsaWRhdGUiOjYwLCJleHBpcmUiOjM2MDB9LCJob3VycyI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjozNjAwLCJleHBpcmUiOjg2NDAwfSwiZGF5cyI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjo4NjQwMCwiZXhwaXJlIjo2MDQ4MDB9LCJ3ZWVrcyI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjo2MDQ4MDAsImV4cGlyZSI6MjU5MjAwMH0sIm1heCI6eyJzdGFsZSI6MzAwLCJyZXZhbGlkYXRlIjoyNTkyMDAwLCJleHBpcmUiOjQyOTQ5NjcyOTR9fSwibXVsdGlab25lRHJhZnRNb2RlIjpmYWxzZSwiYXBwTmF2RmFpbEhhbmRsaW5nIjpmYWxzZSwicHJlcmVuZGVyRWFybHlFeGl0Ijp0cnVlLCJzZXJ2ZXJNaW5pZmljYXRpb24iOnRydWUsInNlcnZlclNvdXJjZU1hcHMiOmZhbHNlLCJsaW5rTm9Ub3VjaFN0YXJ0IjpmYWxzZSwiY2FzZVNlbnNpdGl2ZVJvdXRlcyI6ZmFsc2UsInByZWxvYWRFbnRyaWVzT25TdGFydCI6dHJ1ZSwiY2xpZW50Um91dGVyRmlsdGVyIjp0cnVlLCJjbGllbnRSb3V0ZXJGaWx0ZXJSZWRpcmVjdHMiOmZhbHNlLCJmZXRjaENhY2hlS2V5UHJlZml4IjoiIiwibWlkZGxld2FyZVByZWZldGNoIjoiZmxleGlibGUiLCJvcHRpbWlzdGljQ2xpZW50Q2FjaGUiOnRydWUsIm1hbnVhbENsaWVudEJhc2VQYXRoIjpmYWxzZSwiY3B1cyI6MTksIm1lbW9yeUJhc2VkV29ya2Vyc0NvdW50IjpmYWxzZSwiaXNyRmx1c2hUb0Rpc2siOnRydWUsIndvcmtlclRocmVhZHMiOmZhbHNlLCJvcHRpbWl6ZUNzcyI6ZmFsc2UsIm5leHRTY3JpcHRXb3JrZXJzIjpmYWxzZSwic2Nyb2xsUmVzdG9yYXRpb24iOmZhbHNlLCJleHRlcm5hbERpciI6ZmFsc2UsImRpc2FibGVPcHRpbWl6ZWRMb2FkaW5nIjpmYWxzZSwiZ3ppcFNpemUiOnRydWUsImNyYUNvbXBhdCI6ZmFsc2UsImVzbUV4dGVybmFscyI6dHJ1ZSwiZnVsbHlTcGVjaWZpZWQiOmZhbHNlLCJzd2NUcmFjZVByb2ZpbGluZyI6ZmFsc2UsImZvcmNlU3djVHJhbnNmb3JtcyI6ZmFsc2UsImxhcmdlUGFnZURhdGFCeXRlcyI6MTI4MDAwLCJ0dXJibyI6eyJyb290IjoiL3RtcC9uZXh0LXN0YXRzUkhndll6L3N0YXRzLWFwcCJ9LCJ0eXBlZFJvdXRlcyI6ZmFsc2UsInR5cGVkRW52IjpmYWxzZSwicGFyYWxsZWxTZXJ2ZXJDb21waWxlcyI6ZmFsc2UsInBhcmFsbGVsU2VydmVyQnVpbGRUcmFjZXMiOmZhbHNlLCJwcHIiOmZhbHNlLCJ3ZWJwYWNrTWVtb3J5T3B0aW1pemF0aW9ucyI6ZmFsc2UsIm9wdGltaXplU2VydmVyUmVhY3QiOnRydWUsInVzZUVhcmx5SW1wb3J0IjpmYWxzZSwic3RhbGVUaW1lcyI6eyJkeW5hbWljIjowLCJzdGF0aWMiOjMwMH0sImFmdGVyIjpmYWxzZSwic2VydmVyQ29tcG9uZW50c0htckNhY2hlIjp0cnVlLCJzdGF0aWNHZW5lcmF0aW9uTWF4Q29uY3VycmVuY3kiOjgsInN0YXRpY0dlbmVyYXRpb25NaW5QYWdlc1BlcldvcmtlciI6MjUsImR5bmFtaWNJTyI6ZmFsc2UsIm9wdGltaXplUGFja2FnZUltcG9ydHMiOlsibHVjaWRlLXJlYWN0IiwiZGF0ZS1mbnMiLCJsb2Rhc2gtZXMiLCJyYW1kYSIsImFudGQiLCJyZWFjdC1ib290c3RyYXAiLCJhaG9va3MiLCJAYW50LWRlc2lnbi9pY29ucyIsIkBoZWFkbGVzc3VpL3JlYWN0IiwiQGhlYWRsZXNzdWktZmxvYXQvcmVhY3QiLCJAaGVyb2ljb25zL3JlYWN0LzIwL3NvbGlkIiwiQGhlcm9pY29ucy9yZWFjdC8yNC9zb2xpZCIsIkBoZXJvaWNvbnMvcmVhY3QvMjQvb3V0bGluZSIsIkB2aXN4L3Zpc3giLCJAdHJlbW9yL3JlYWN0IiwicnhqcyIsIkBtdWkvbWF0ZXJpYWwiLCJAbXVpL2ljb25zLW1hdGVyaWFsIiwicmVjaGFydHMiLCJyZWFjdC11c2UiLCJlZmZlY3QiLCJAZWZmZWN0L3NjaGVtYSIsIkBlZmZlY3QvcGxhdGZvcm0iLCJAZWZmZWN0L3BsYXRmb3JtLW5vZGUiLCJAZWZmZWN0L3BsYXRmb3JtLWJyb3dzZXIiLCJAZWZmZWN0L3BsYXRmb3JtLWJ1biIsIkBlZmZlY3Qvc3FsIiwiQGVmZmVjdC9zcWwtbXNzcWwiLCJAZWZmZWN0L3NxbC1teXNxbDIiLCJAZWZmZWN0L3NxbC1wZyIsIkBlZmZlY3Qvc3FsLXNxdWxpdGUtbm9kZSIsIkBlZmZlY3Qvc3FsLXNxdWxpdGUtYnVuIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS13YXNtIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS1yZWFjdC1uYXRpdmUiLCJAZWZmZWN0L3JwYyIsIkBlZmZlY3QvcnBjLWh0dHAiLCJAZWZmZWN0L3R5cGVjbGFzcyIsIkBlZmZlY3QvZXhwZXJpbWVudGFsIiwiQGVmZmVjdC9vcGVudGVsZW1ldHJ5IiwiQG1hdGVyaWFsLXVpL2NvcmUiLCJAbWF0ZXJpYWwtdWkvaWNvbnMiLCJAdGFibGVyL2ljb25zLXJlYWN0IiwibXVpLWNvcmUiLCJyZWFjdC1pY29ucy9haSIsInJlYWN0LWljb25zL2JpIiwicmVhY3QtaWNvbnMvYnMiLCJyZWFjdC1pY29ucy9jZyIsInJlYWN0LWljb25zL2NpIiwicmVhY3QtaWNvbnMvZGkiLCJyZWFjdC1pY29ucy9mYSIsInJlYWN0LWljb25zL2ZhNiIsInJlYWN0LWljb25zL2ZjIiwicmVhY3QtaWNvbnMvZmkiLCJyZWFjdC1pY29ucy9naSIsInJlYWN0LWljb25zL2dvIiwicmVhY3QtaWNvbnMvZ3IiLCJyZWFjdC1pY29ucy9oaSIsInJlYWN0LWljb25zL2hpMiIsInJlYWN0LWljb25zL2ltIiwicmVhY3QtaWNvbnMvaW8iLCJyZWFjdC1pY29ucy9pbzUiLCJyZWFjdC1pY29ucy9saWEiLCJyZWFjdC1pY29ucy9saWIiLCJyZWFjdC1pY29ucy9sdSIsInJlYWN0LWljb25zL21kIiwicmVhY3QtaWNvbnMvcGkiLCJyZWFjdC1pY29ucy9yaSIsInJlYWN0LWljb25zL3J4IiwicmVhY3QtaWNvbnMvc2kiLCJyZWFjdC1pY29ucy9zbCIsInJlYWN0LWljb25zL3RiIiwicmVhY3QtaWNvbnMvdGZpIiwicmVhY3QtaWNvbnMvdGkiLCJyZWFjdC1pY29ucy92c2MiLCJyZWFjdC1pY29ucy93aSJdfSwiYnVuZGxlUGFnZXNSb3V0ZXJEZXBlbmRlbmNpZXMiOmZhbHNlLCJjb25maWdGaWxlIjoiL3RtcC9uZXh0LXN0YXRzUkhndll6L3N0YXRzLWFwcC9uZXh0LmNvbmZpZy5qcyIsImNvbmZpZ0ZpbGVOYW1lIjoibmV4dC5jb25maWcuanMifQ==","pagesType":"app","appDirLoader":"bmV4dC1hcHAtbG9hZGVyP25hbWU9YXBwJTJGYXBwLWVkZ2Utc3NyJTJGcGFnZSZwYWdlPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZVBhdGg9cHJpdmF0ZS1uZXh0LWFwcC1kaXIlMkZhcHAtZWRnZS1zc3IlMkZwYWdlLmpzJmFwcERpcj0lMkZ0bXAlMkZuZXh0LXN0YXRzUkhndll6JTJGc3RhdHMtYXBwJTJGYXBwJmFwcFBhdGhzPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZUV4dGVuc2lvbnM9dHN4JnBhZ2VFeHRlbnNpb25zPXRzJnBhZ2VFeHRlbnNpb25zPWpzeCZwYWdlRXh0ZW5zaW9ucz1qcyZiYXNlUGF0aD0mYXNzZXRQcmVmaXg9Jm5leHRDb25maWdPdXRwdXQ9JmZseWluZ1NodXR0bGU9ZmFsc2UmcHJlZmVycmVkUmVnaW9uPSZtaWRkbGV3YXJlQ29uZmlnPWUzMCUzRCE=","sriEnabled":false,"middlewareConfig":"e30="}!
       var _self___RSC_MANIFEST;
 
       const incrementalCacheHandler = null;
@@ -451,56 +451,56 @@
       /***/
     },
 
-    /***/ 143: /***/ (
+    /***/ 7359: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
     ) => {
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 7296)
+        __webpack_require__.bind(__webpack_require__, 8507)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 471)
+        __webpack_require__.bind(__webpack_require__, 4468)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 1633)
+        __webpack_require__.bind(__webpack_require__, 6308)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 4050)
+        __webpack_require__.bind(__webpack_require__, 5768)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 8666)
+        __webpack_require__.bind(__webpack_require__, 6552)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 8357)
+        __webpack_require__.bind(__webpack_require__, 7140)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 2286)
+        __webpack_require__.bind(__webpack_require__, 1201)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 1376)
+        __webpack_require__.bind(__webpack_require__, 4979)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 4147)
+        __webpack_require__.bind(__webpack_require__, 964)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 5890)
+        __webpack_require__.bind(__webpack_require__, 6454)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 8279)
+        __webpack_require__.bind(__webpack_require__, 3097)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 5734)
+        __webpack_require__.bind(__webpack_require__, 9435)
       );
 
       /***/
     },
 
-    /***/ 6455: /***/ () => {
+    /***/ 7060: /***/ () => {
       /***/
     },
 
-    /***/ 2266: /***/ (
+    /***/ 4260: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -520,7 +520,7 @@
       /***/
     },
 
-    /***/ 2481: /***/ (
+    /***/ 5886: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -532,7 +532,7 @@
         /* harmony export */
       });
       /* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
-        __webpack_require__(396);
+        __webpack_require__(2674);
 
       function RootLayout({ children }) {
         return /*#__PURE__*/ (0,
@@ -551,7 +551,7 @@
     // webpackRuntimeModules
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
-    /******/ __webpack_require__.O(0, [85, 974], () => __webpack_exec__(7610));
+    /******/ __webpack_require__.O(0, [728, 339], () => __webpack_exec__(8282));
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ (_ENTRIES = typeof _ENTRIES === "undefined" ? {} : _ENTRIES)[
       "middleware_app/app-edge-ssr/page"

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for image-HASH.js

@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [8358],
   {
-    /***/ 1250: /***/ (
+    /***/ 3999: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function () {
-          return __webpack_require__(9810);
+          return __webpack_require__(5549);
         },
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 8202: /***/ (module, exports, __webpack_require__) => {
+    /***/ 7798: /***/ (module, exports, __webpack_require__) => {
       "use strict";
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
@@ -40,17 +40,17 @@
         __webpack_require__(8478)
       );
       const _head = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(8477)
+        __webpack_require__(2274)
       );
-      const _getimgprops = __webpack_require__(8338);
-      const _imageconfig = __webpack_require__(1857);
-      const _imageconfigcontextsharedruntime = __webpack_require__(9307);
-      const _warnonce = __webpack_require__(3608);
-      const _routercontextsharedruntime = __webpack_require__(4210);
+      const _getimgprops = __webpack_require__(107);
+      const _imageconfig = __webpack_require__(5162);
+      const _imageconfigcontextsharedruntime = __webpack_require__(5888);
+      const _warnonce = __webpack_require__(1402);
+      const _routercontextsharedruntime = __webpack_require__(6322);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(7858)
+        __webpack_require__(3164)
       );
-      const _usemergedref = __webpack_require__(308);
+      const _usemergedref = __webpack_require__(3994);
       // This is replaced by webpack define plugin
       const configEnv = {
         deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
       /***/
     },
 
-    /***/ 308: /***/ (module, exports, __webpack_require__) => {
+    /***/ 3994: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -432,7 +432,7 @@
       /***/
     },
 
-    /***/ 8338: /***/ (
+    /***/ 107: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -448,9 +448,9 @@
           return getImgProps;
         },
       });
-      const _warnonce = __webpack_require__(3608);
-      const _imageblursvg = __webpack_require__(7048);
-      const _imageconfig = __webpack_require__(1857);
+      const _warnonce = __webpack_require__(1402);
+      const _imageblursvg = __webpack_require__(9828);
+      const _imageconfig = __webpack_require__(5162);
       const VALID_LOADING_VALUES =
         /* unused pure expression or super */ null && [
           "lazy",
@@ -824,7 +824,7 @@
       /***/
     },
 
-    /***/ 7048: /***/ (__unused_webpack_module, exports) => {
+    /***/ 9828: /***/ (__unused_webpack_module, exports) => {
       "use strict";
       /**
        * A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -879,7 +879,7 @@
       /***/
     },
 
-    /***/ 9659: /***/ (
+    /***/ 1874: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -906,10 +906,10 @@
         },
       });
       const _interop_require_default = __webpack_require__(9608);
-      const _getimgprops = __webpack_require__(8338);
-      const _imagecomponent = __webpack_require__(8202);
+      const _getimgprops = __webpack_require__(107);
+      const _imagecomponent = __webpack_require__(7798);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(7858)
+        __webpack_require__(3164)
       );
       function getImageProps(imgProps) {
         const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -941,7 +941,7 @@
       /***/
     },
 
-    /***/ 7858: /***/ (__unused_webpack_module, exports) => {
+    /***/ 3164: /***/ (__unused_webpack_module, exports) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -976,7 +976,7 @@
       /***/
     },
 
-    /***/ 9810: /***/ (
+    /***/ 5549: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -993,8 +993,8 @@
 
       // EXTERNAL MODULE: ./node_modules/.pnpm/react@19.0.0-rc-77b637d6-20241016/node_modules/react/jsx-runtime.js
       var jsx_runtime = __webpack_require__(1898);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_ffcj6laqwfrprjtqepf4aci7ry/node_modules/next/image.js
-      var next_image = __webpack_require__(891);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-77b637d6-20241016_re_s6kfxaszauf4se3ryj52xqgc44/node_modules/next/image.js
+      var next_image = __webpack_require__(1107);
       var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
       /* harmony default export */ const nextjs = {
         src: "/_next/static/media/nextjs.cae0b805.png",
@@ -1024,12 +1024,12 @@
       /***/
     },
 
-    /***/ 891: /***/ (
+    /***/ 1107: /***/ (
       module,
       __unused_webpack_exports,
       __webpack_require__
     ) => {
-      module.exports = __webpack_require__(9659);
+      module.exports = __webpack_require__(1874);
 
       /***/
     },
@@ -1039,7 +1039,7 @@
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
     /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
-      __webpack_exec__(1250)
+      __webpack_exec__(3999)
     );
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;

Diff for 9327-HASH.js

@@ -1,8 +1,8 @@
 "use strict";
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
-  [9327],
+  [8881],
   {
-    /***/ 7541: /***/ (module, exports, __webpack_require__) => {
+    /***/ 8881: /***/ (module, exports, __webpack_require__) => {
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
         value: true,
@@ -13,27 +13,27 @@
           return Image;
         },
       });
-      const _interop_require_default = __webpack_require__(8352);
-      const _interop_require_wildcard = __webpack_require__(9982);
-      const _jsxruntime = __webpack_require__(7150);
+      const _interop_require_default = __webpack_require__(2461);
+      const _interop_require_wildcard = __webpack_require__(9417);
+      const _jsxruntime = __webpack_require__(7580);
       const _react = /*#__PURE__*/ _interop_require_wildcard._(
-        __webpack_require__(3576)
+        __webpack_require__(268)
       );
       const _reactdom = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(3603)
+        __webpack_require__(877)
       );
       const _head = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(2605)
+        __webpack_require__(3575)
       );
-      const _getimgprops = __webpack_require__(2396);
-      const _imageconfig = __webpack_require__(3231);
-      const _imageconfigcontextsharedruntime = __webpack_require__(1798);
-      const _warnonce = __webpack_require__(9950);
-      const _routercontextsharedruntime = __webpack_require__(47);
+      const _getimgprops = __webpack_require__(9379);
+      const _imageconfig = __webpack_require__(2579);
+      const _imageconfigcontextsharedruntime = __webpack_require__(833);
+      const _warnonce = __webpack_require__(4832);
+      const _routercontextsharedruntime = __webpack_require__(2899);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(1988)
+        __webpack_require__(7948)
       );
-      const _usemergedref = __webpack_require__(1046);
+      const _usemergedref = __webpack_require__(9977);
       // This is replaced by webpack define plugin
       const configEnv = {
         deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -355,7 +355,7 @@
       /***/
     },
 
-    /***/ 1046: /***/ (module, exports, __webpack_require__) => {
+    /***/ 9977: /***/ (module, exports, __webpack_require__) => {
       Object.defineProperty(exports, "__esModule", {
         value: true,
       });
@@ -365,7 +365,7 @@
           return useMergedRef;
         },
       });
-      const _react = __webpack_require__(3576);
+      const _react = __webpack_require__(268);
       function useMergedRef(refA, refB) {
         const cleanupA = (0, _react.useRef)(() => {});
         const cleanupB = (0, _react.useRef)(() => {});
@@ -414,7 +414,7 @@
       /***/
     },
 
-    /***/ 8952: /***/ (
+    /***/ 5392: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -428,9 +428,9 @@
           return AmpStateContext;
         },
       });
-      const _interop_require_default = __webpack_require__(8352);
+      const _interop_require_default = __webpack_require__(2461);
       const _react = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(3576)
+        __webpack_require__(268)
       );
       const AmpStateContext = _react.default.createContext({});
       if (false) {
@@ -439,7 +439,7 @@
       /***/
     },
 
-    /***/ 6524: /***/ (__unused_webpack_module, exports) => {
+    /***/ 639: /***/ (__unused_webpack_module, exports) => {
       Object.defineProperty(exports, "__esModule", {
         value: true,
       });
@@ -461,7 +461,7 @@
       /***/
     },
 
-    /***/ 2396: /***/ (
+    /***/ 9379: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -475,9 +475,9 @@
           return getImgProps;
         },
       });
-      const _warnonce = __webpack_require__(9950);
-      const _imageblursvg = __webpack_require__(7386);
-      const _imageconfig = __webpack_require__(3231);
+      const _warnonce = __webpack_require__(4832);
+      const _imageblursvg = __webpack_require__(8912);
+      const _imageconfig = __webpack_require__(2579);
       const VALID_LOADING_VALUES =
         /* unused pure expression or super */ null && [
           "lazy",
@@ -851,8 +851,8 @@
       /***/
     },
 
-    /***/ 2605: /***/ (module, exports, __webpack_require__) => {
-      /* provided dependency */ var process = __webpack_require__(2019);
+    /***/ 3575: /***/ (module, exports, __webpack_require__) => {
+      /* provided dependency */ var process = __webpack_require__(540);
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
         value: true,
@@ -873,19 +873,19 @@
           return defaultHead;
         },
       });
-      const _interop_require_default = __webpack_require__(8352);
-      const _interop_require_wildcard = __webpack_require__(9982);
-      const _jsxruntime = __webpack_require__(7150);
+      const _interop_require_default = __webpack_require__(2461);
+      const _interop_require_wildcard = __webpack_require__(9417);
+      const _jsxruntime = __webpack_require__(7580);
       const _react = /*#__PURE__*/ _interop_require_wildcard._(
-        __webpack_require__(3576)
+        __webpack_require__(268)
       );
       const _sideeffect = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(7592)
+        __webpack_require__(4591)
       );
-      const _ampcontextsharedruntime = __webpack_require__(8952);
-      const _headmanagercontextsharedruntime = __webpack_require__(5024);
-      const _ampmode = __webpack_require__(6524);
-      const _warnonce = __webpack_require__(9950);
+      const _ampcontextsharedruntime = __webpack_require__(5392);
+      const _headmanagercontextsharedruntime = __webpack_require__(9454);
+      const _ampmode = __webpack_require__(639);
+      const _warnonce = __webpack_require__(4832);
       function defaultHead(inAmpMode) {
         if (inAmpMode === void 0) inAmpMode = false;
         const head = [
@@ -1069,7 +1069,7 @@
       /***/
     },
 
-    /***/ 7386: /***/ (__unused_webpack_module, exports) => {
+    /***/ 8912: /***/ (__unused_webpack_module, exports) => {
       /**
        * A shared function, used on both client and server, to generate a SVG blur placeholder.
        */
@@ -1123,7 +1123,7 @@
       /***/
     },
 
-    /***/ 1798: /***/ (
+    /***/ 833: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -1137,11 +1137,11 @@
           return ImageConfigContext;
         },
       });
-      const _interop_require_default = __webpack_require__(8352);
+      const _interop_require_default = __webpack_require__(2461);
       const _react = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(3576)
+        __webpack_require__(268)
       );
-      const _imageconfig = __webpack_require__(3231);
+      const _imageconfig = __webpack_require__(2579);
       const ImageConfigContext = _react.default.createContext(
         _imageconfig.imageConfigDefault
       );
@@ -1151,7 +1151,7 @@
       /***/
     },
 
-    /***/ 3231: /***/ (__unused_webpack_module, exports) => {
+    /***/ 2579: /***/ (__unused_webpack_module, exports) => {
       Object.defineProperty(exports, "__esModule", {
         value: true,
       });
@@ -1199,7 +1199,7 @@
       /***/
     },
 
-    /***/ 1988: /***/ (__unused_webpack_module, exports) => {
+    /***/ 7948: /***/ (__unused_webpack_module, exports) => {
       Object.defineProperty(exports, "__esModule", {
         value: true,
       });
@@ -1232,7 +1232,11 @@
       /***/
     },
 
-    /***/ 47: /***/ (__unused_webpack_module, exports, __webpack_require__) => {
+    /***/ 2899: /***/ (
+      __unused_webpack_module,
+      exports,
+      __webpack_require__
+    ) => {
       Object.defineProperty(exports, "__esModule", {
         value: true,
       });
@@ -1242,9 +1246,9 @@
           return RouterContext;
         },
       });
-      const _interop_require_default = __webpack_require__(8352);
+      const _interop_require_default = __webpack_require__(2461);
       const _react = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(3576)
+        __webpack_require__(268)
       );
       const RouterContext = _react.default.createContext(null);
       if (false) {
@@ -1253,7 +1257,7 @@
       /***/
     },
 
-    /***/ 7592: /***/ (
+    /***/ 4591: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -1267,7 +1271,7 @@
           return SideEffect;
         },
       });
-      const _react = __webpack_require__(3576);
+      const _react = __webpack_require__(268);
       const isServer = typeof window === "undefined";
       const useClientOnlyLayoutEffect = isServer
         ? () => {}

Diff for 9988-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 5384488

bgw · 2024-10-18T01:33:17Z

turbopack/crates/turbo-tasks-backend/src/backend/mod.rs

            // Safety: `tx` is a valid transaction from `self.backend.backing_storage`.
-            unsafe { self.connect_child_with_tx(tx, parent_task, task_id, turbo_tasks) };


Intentional removal?

I moved the duplicated code further down

bgw · 2024-10-18T01:50:58Z

turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs

+                // Safety: self is actually valid for 'a, so it's safe to transmute 'l to 'a
+                unsafe { transmute::<B::ReadTransaction<'_>, B::ReadTransaction<'tx>>(tx) }


The lifetimes in this comment don't match this code. I'm a bit skeptical of the validity of the cast, but I don't know enough to say anything for sure.

bgw · 2024-10-18T02:15:52Z

turbopack/crates/turbo-tasks-backend/src/backend/storage.rs

+        #[allow(unused_imports)]
+        use $crate::backend::operation::TaskGuard;


Suggested change

#[allow(unused_imports)]

use $crate::backend::operation::TaskGuard;

// `$task` might be a `TaskGuard` type, in which case, `.get()` might call `TaskGuard::get`

#[allow(unused_imports)]

use $crate::backend::operation::TaskGuard as _;

You don't need to copy the comment everywhere, but the as _ should be copied for all of these macros. It's just there to avoid any unnecessary shadowing of the TaskGuard name in the macro.

If you know for certain that $task is always a TaskGuard, you should probably remove the import and just replace the method call with $crate::backend::operation::TaskGuard::get($task) instead. Performing method resolution inside macros can have unexpected results.

bgw · 2024-10-18T02:21:28Z

turbopack/crates/turbo-tasks-backend/src/database/db_versioning.rs

+                        }
+                        (
+                            p,
+                            get_age(p).unwrap_or(Duration::from_secs(10 * 356 * 24 * 60 * 60)),


IMO, I'd put this duration value in a far_future helper function like tokio does: https://github.com/tokio-rs/tokio/blob/1656d8e231903a7b84b9e2d5e3db7aeed13a2966/tokio/src/time/instant.rs#L57

Because:

That better signals intent

It's actually pretty common IMO to want some sort of far_future/Duration::MAX sort of thing, and it sucks that the stdlib doesn't provide it.

bgw · 2024-10-18T02:33:15Z

turbopack/crates/turbo-tasks-backend/src/database/lmdb/mod.rs

+        #[cfg(target_arch = "x86")]
+        const MAP_SIZE: usize = usize::MAX;
+        #[cfg(not(target_arch = "x86"))]
+        const MAP_SIZE: usize = 40 * 1024 * 1024 * 1024;


Suggested change

#[cfg(target_arch = "x86")]

const MAP_SIZE: usize = usize::MAX;

#[cfg(not(target_arch = "x86"))]

const MAP_SIZE: usize = 40 * 1024 * 1024 * 1024;

#[cfg(target_pointer_width = "32")]

const MAP_SIZE: usize = usize::MAX;

#[cfg(not(target_pointer_width = "32"))]

const MAP_SIZE: usize = 40 * 1024 * 1024 * 1024;

I see you're just moving this around, and I probably missed this in previous reviews, but it's probably better to use target_pointer_width here? If only because it's clearer about what's happening?

Also, usize::MAX probably isn't okay to use on a 32bit arch? You'd have no memory left to run the program after mmapping the database? You probably need to use something like usize::MAX / 2?

Also, I saw we dropped our x86 windows target, so maybe I'm just being silly at this point.

ijjk · 2024-10-18T09:57:32Z

Tests Passed

sokra · 2024-10-18T10:34:42Z

Merge activity

Oct 18, 6:34 AM EDT: A user merged this pull request with Graphite.

### What? refactor BackingStore to allow different KeyValueDatabases, avoid dynamic calls and have ReadTransactions and ValueBuffer as trait associated type. Also adds a default backing storage to be used by next.js

ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Oct 17, 2024

This was referenced Oct 17, 2024

[Turbopack] Perf improvement new backend aggregation #71356

Merged

[Turbopack] add a startup cache which caches the first 100MB of accessed data #71431

Merged

sokra requested a review from bgw October 17, 2024 15:03

sokra marked this pull request as ready for review October 17, 2024 15:05

sokra changed the title ~~refactor to allow different key value stores~~ [Turbopack] refactor to allow different key value stores Oct 17, 2024

This was referenced Oct 17, 2024

add sled as database #71432

Draft

add dump database #71433

Draft

bgw approved these changes Oct 18, 2024

View reviewed changes

sokra force-pushed the sokra/refactor-different-dbs branch from 669bb87 to a41c989 Compare October 18, 2024 05:50

sokra mentioned this pull request Oct 18, 2024

[Turbopack] make snapshot organization more efficient #71466

Merged

sokra force-pushed the sokra/aggregation-efficiency branch from cdecb92 to f22389d Compare October 18, 2024 05:58

sokra force-pushed the sokra/refactor-different-dbs branch from a41c989 to c44ab3d Compare October 18, 2024 05:58

sokra force-pushed the sokra/aggregation-efficiency branch from f22389d to e67eac8 Compare October 18, 2024 08:43

sokra force-pushed the sokra/refactor-different-dbs branch from c44ab3d to bebe607 Compare October 18, 2024 08:45

Base automatically changed from sokra/aggregation-efficiency to canary October 18, 2024 09:41

sokra added 7 commits October 18, 2024 09:43

refactor to allow different key value stores

a490eee

improve lifetime

ae65654

clippy

881c39b

make returned value parameterized

cb960b2

add default backing storage

3d8fc45

add noop backing storage factory

87f38e6

clippy

5384488

sokra force-pushed the sokra/refactor-different-dbs branch from bebe607 to 5384488 Compare October 18, 2024 09:43

sokra merged commit e8e1eb9 into canary Oct 18, 2024
103 of 108 checks passed

sokra deleted the sokra/refactor-different-dbs branch October 18, 2024 10:34

github-actions bot added the locked label Nov 1, 2024

github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Turbopack] refactor to allow different key value stores #71430

[Turbopack] refactor to allow different key value stores #71430

sokra commented Oct 17, 2024 •

edited

Loading

sokra commented Oct 17, 2024 •

edited

Loading

ijjk commented Oct 17, 2024 •

edited

Loading

bgw Oct 18, 2024

sokra Oct 18, 2024

bgw Oct 18, 2024

bgw Oct 18, 2024

bgw Oct 18, 2024

bgw Oct 18, 2024

ijjk commented Oct 18, 2024 •

edited

Loading

sokra commented Oct 18, 2024

		// Safety: `tx` is a valid transaction from `self.backend.backing_storage`.
		unsafe { self.connect_child_with_tx(tx, parent_task, task_id, turbo_tasks) };

		// Safety: self is actually valid for 'a, so it's safe to transmute 'l to 'a
		unsafe { transmute::<B::ReadTransaction<'_>, B::ReadTransaction<'tx>>(tx) }

		#[allow(unused_imports)]
		use $crate::backend::operation::TaskGuard;

[Turbopack] refactor to allow different key value stores #71430

[Turbopack] refactor to allow different key value stores #71430

Conversation

sokra commented Oct 17, 2024 • edited Loading

What?

sokra commented Oct 17, 2024 • edited Loading

ijjk commented Oct 17, 2024 • edited Loading

Stats from current PR

bgw Oct 18, 2024

Choose a reason for hiding this comment

sokra Oct 18, 2024

Choose a reason for hiding this comment

bgw Oct 18, 2024

Choose a reason for hiding this comment

bgw Oct 18, 2024

Choose a reason for hiding this comment

bgw Oct 18, 2024

Choose a reason for hiding this comment

bgw Oct 18, 2024

Choose a reason for hiding this comment

ijjk commented Oct 18, 2024 • edited Loading

Tests Passed

sokra commented Oct 18, 2024

Merge activity

sokra commented Oct 17, 2024 •

edited

Loading

sokra commented Oct 17, 2024 •

edited

Loading

ijjk commented Oct 17, 2024 •

edited

Loading

ijjk commented Oct 18, 2024 •

edited

Loading