Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment and auth links to align with Next.js App Router #71589

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

mayur9210
Copy link
Contributor

This PR addresses the following fixes:

fix: update the deployment link to Next.js App Router

  • Updated the deployment link to point to the Next.js App Router instead of the Pages Router since the example now has the pages router

fix: App Router deployment link for app-dir-i18n-routing example

  • Corrected the deployment link for the app-dir-i18n-routing example to match the App Router deployment structure.

fix: Stytch auth link updated to Next.js

  • Updated the Stytch authentication link to work with the Next.js setup, previous link was pointed to Javascript example.

@ijjk ijjk added the examples Issue/PR related to examples label Oct 22, 2024
@ijjk
Copy link
Member

ijjk commented Oct 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: 3658248

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk enabled auto-merge (squash) October 29, 2024 19:34
@ijjk ijjk merged commit 420ba68 into vercel:canary Oct 29, 2024
38 checks passed
kdy1 pushed a commit that referenced this pull request Oct 30, 2024
This PR addresses the following fixes:

**fix: update the deployment link to Next.js App Router**
- Updated the deployment link to point to the Next.js App Router instead
of the Pages Router since the example now has the pages router

**fix: App Router deployment link for app-dir-i18n-routing example**
- Corrected the deployment link for the app-dir-i18n-routing example to
match the App Router deployment structure.

**fix: Stytch auth link updated to Next.js**
- Updated the Stytch authentication link to work with the Next.js setup,
previous link was pointed to Javascript example.

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
stipsan pushed a commit to sanity-io/next.js that referenced this pull request Nov 6, 2024
…l#71589)

This PR addresses the following fixes:

**fix: update the deployment link to Next.js App Router**
- Updated the deployment link to point to the Next.js App Router instead
of the Pages Router since the example now has the pages router

**fix: App Router deployment link for app-dir-i18n-routing example**
- Corrected the deployment link for the app-dir-i18n-routing example to
match the App Router deployment structure.

**fix: Stytch auth link updated to Next.js**
- Updated the Stytch authentication link to work with the Next.js setup,
previous link was pointed to Javascript example.

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants