Skip to content

fixes error message asserts and lints #71747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnoff merged 1 commit into from
Oct 23, 2024
Merged

fixes error message asserts and lints #71747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/app-dir/dynamic-io-errors/dynamic-io-errors.prospective-fallback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe(`Dynamic IO Prospective Fallback`, () => {
}

expect(next.cliOutput).toContain(
'In Route "/blog/[slug]" this component accessed data without a fallback UI available somewhere above it using Suspense.'
'In Route "/blog/[slug]" this component accessed data without a Suspense boundary above it to provide a fallback UI.'
)
})

Expand All @@ -46,7 +46,7 @@ describe(`Dynamic IO Prospective Fallback`, () => {
await next.start()

expect(next.cliOutput).not.toContain(
'In Route "/blog/[slug]" this component accessed data without a fallback UI available somewhere above it using Suspense.'
'In Route "/blog/[slug]" this component accessed data without a Suspense boundary above it to provide a fallback UI.'
)
})
}
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/dynamic-io-errors/dynamic-io-errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ function runTests(options: { withMinification: boolean }) {
const expectError = createExpectError(next.cliOutput)

expectError(
'In Route "/" this component accessed data without a fallback UI available somewhere above it using Suspense.',
'In Route "/" this component accessed data without a Suspense boundary above it to provide a fallback UI.',
// Turbopack doesn't support disabling minification yet
withMinification || isTurbopack ? undefined : 'IndirectionTwo'
)
Expand All @@ -331,7 +331,7 @@ function runTests(options: { withMinification: boolean }) {
// one task actually reports and error at the moment. We should fix upstream but for now we exclude the second error when PPR is off
// because we are using canary React and renderToReadableStream rather than experimental React and prerender
expectError(
'In Route "/" this component accessed data without a fallback UI available somewhere above it using Suspense.',
'In Route "/" this component accessed data without a Suspense boundary above it to provide a fallback UI.',
// Turbopack doesn't support disabling minification yet
withMinification || isTurbopack ? undefined : 'IndirectionThree'
)
Expand Down
Loading