Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix URL for error message #71788

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Marukome0743
Copy link
Contributor

@Marukome0743 Marukome0743 commented Oct 24, 2024

Description

Fix URL for https://nextjs.org/docs/messages/missing-root-layout-tags

❌wrong: https://nextjs.org/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required
✅correct: https://nextjs.org/docs/app/building-your-application/routing/layouts-and-templates#root-layout-required

Improving Documentation

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Oct 24, 2024
@ijjk
Copy link
Member

ijjk commented Oct 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 6387291

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Marukome0743 Marukome0743 force-pushed the 10-09-docs_fix_url_for_error_message branch 2 times, most recently from b1056fa to 36b36bd Compare October 28, 2024 03:35
@Marukome0743 Marukome0743 force-pushed the 10-09-docs_fix_url_for_error_message branch from 36b36bd to 6387291 Compare October 29, 2024 08:14
@ijjk ijjk enabled auto-merge (squash) October 29, 2024 18:56
@ijjk ijjk merged commit 7308aa8 into vercel:canary Oct 29, 2024
38 checks passed
@Marukome0743 Marukome0743 deleted the 10-09-docs_fix_url_for_error_message branch October 30, 2024 00:25
kdy1 pushed a commit that referenced this pull request Oct 30, 2024
## Description
Fix URL for https://nextjs.org/docs/messages/missing-root-layout-tags

❌wrong:
https://nextjs.org/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required
✅correct:
https://nextjs.org/docs/app/building-your-application/routing/layouts-and-templates#root-layout-required

### Improving Documentation

- [x] Run `pnpm prettier-fix` to fix formatting issues before opening
the PR.
- [x] Read the Docs Contribution Guide to ensure your contribution
follows the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

Co-authored-by: JJ Kasper <jj@jjsweb.site>
stipsan pushed a commit to sanity-io/next.js that referenced this pull request Nov 6, 2024
## Description
Fix URL for https://nextjs.org/docs/messages/missing-root-layout-tags

❌wrong:
https://nextjs.org/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required
✅correct:
https://nextjs.org/docs/app/building-your-application/routing/layouts-and-templates#root-layout-required

### Improving Documentation

- [x] Run `pnpm prettier-fix` to fix formatting issues before opening
the PR.
- [x] Read the Docs Contribution Guide to ensure your contribution
follows the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants