-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify serialization behavior of "use cache" #72286
Conversation
Maybe not ideal wording but this should be more correct. See vercel#72081 (comment).
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
slightly reworded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. Requested a review from @delbaoliveira for final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for further clarifying it Dan.
Tbh, the how use cache
information is so essential that shouldn't live under a good to know. I'll move it out to its own in the future.
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Maybe not ideal wording but this should be more correct. See vercel#72081 (comment). --------- Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com> Co-authored-by: JJ Kasper <jj@jjsweb.site>
Maybe not ideal wording but this should be more correct. See #72081 (comment).