Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify serialization behavior of "use cache" #72286

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Nov 4, 2024

Maybe not ideal wording but this should be more correct. See #72081 (comment).

Maybe not ideal wording but this should be more correct. See vercel#72081 (comment).
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 4, 2024
@ijjk
Copy link
Member

ijjk commented Nov 4, 2024

Allow CI Workflow Run

  • approve CI run for commit: defbbbe

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@gaearon
Copy link
Contributor Author

gaearon commented Nov 4, 2024

slightly reworded.

Copy link
Contributor

@unstubbable unstubbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Requested a review from @delbaoliveira for final approval.

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for further clarifying it Dan.

Tbh, the how use cache information is so essential that shouldn't live under a good to know. I'll move it out to its own in the future.

gaearon and others added 4 commits November 5, 2024 12:20
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@ijjk ijjk enabled auto-merge (squash) November 5, 2024 20:41
@ijjk ijjk merged commit 0a209a9 into vercel:canary Nov 5, 2024
38 checks passed
stipsan pushed a commit to sanity-io/next.js that referenced this pull request Nov 6, 2024
Maybe not ideal wording but this should be more correct. See
vercel#72081 (comment).

---------

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants