Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix static params as promise examples #72553

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

emmanuelgautier
Copy link
Contributor

Improving Documentation

dynamic params from generateStaticParams is now a promise but is now promise in type.
Type has been changed for every Promise params.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 10, 2024
@ijjk
Copy link
Member

ijjk commented Nov 10, 2024

Allow CI Workflow Run

  • approve CI run for commit: c93a7da

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk merged commit 4a203a0 into vercel:canary Nov 22, 2024
39 checks passed
wyattjoh pushed a commit that referenced this pull request Nov 28, 2024
## Improving Documentation

dynamic `params` from `generateStaticParams` is now a promise but is now
promise in type.
Type has been changed for every Promise `params`.

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants