Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data-fetching): fix static params as promise examples #72565

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

devpla
Copy link
Contributor

@devpla devpla commented Nov 11, 2024

Improving Documentation

  • Since the params prop is now a promise, the type of params in the generateMetadata and Page components has been changed from { id: string } to Promise<{ id: string }>.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 11, 2024
@devpla devpla changed the title docs(data-fetching): fix static params as promise examples docs: fix static params as promise examples Nov 11, 2024
@ijjk
Copy link
Member

ijjk commented Nov 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: 5bbe264

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: d786742

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@devpla devpla changed the title docs: fix static params as promise examples docs: fix static params as promise examples (data fetching) Nov 11, 2024
@devpla devpla changed the title docs: fix static params as promise examples (data fetching) docs(data fetching): fix static params as promise examples Nov 12, 2024
@devpla devpla changed the title docs(data fetching): fix static params as promise examples docs(data-fetching): fix static params as promise examples Nov 12, 2024
@ijjk ijjk enabled auto-merge (squash) November 12, 2024 21:09
@ijjk ijjk merged commit f705f9a into vercel:canary Nov 12, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants