Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update turbopack document path in the warning message #72597

Merged
merged 4 commits into from
Dec 17, 2024
Merged

chore: update turbopack document path in the warning message #72597

merged 4 commits into from
Dec 17, 2024

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Nov 11, 2024 •
edited
Loading

Description

The page which provided link goes to has a different URL.
It's inconvenience and I update the path.

@ijjk
Copy link
Member

ijjk commented Nov 11, 2024 •
edited by samcx
Loading

Allow CI Workflow Run

  • approve CI run for commit: 03ee972

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@JamBalaya56562 JamBalaya56562 force-pushed the turbopack branch 2 times, most recently from f9fb5c8 to 6d3b9fd Compare November 19, 2024 03:56
@JamBalaya56562 JamBalaya56562 changed the title chore: update turbopack document path chore: update turbopack document path in the warning message Dec 3, 2024
@JamBalaya56562 JamBalaya56562 force-pushed the turbopack branch 4 times, most recently from ca1675e to 7b045e8 Compare December 9, 2024 01:36
@samcx samcx self-requested a review December 10, 2024 06:59
@samcx samcx enabled auto-merge (squash) December 10, 2024 07:00
@samcx samcx disabled auto-merge December 10, 2024 07:02
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024 •
edited
Loading

Failing test suites

Commit: c1e527e

pnpm test test/integration/rewrites-manual-href-as/test/index.test.js

  • rewrites manual href/as > development mode > should allow manual href/as on index page
Expand output

● rewrites manual href/as › development mode › should allow manual href/as on index page

expect(received).toBeTruthy()

Received: false

  28 |
  29 |     expect(await browser.elementByCss('#index').text()).toBe('index page')
> 30 |     expect(await browser.hasElementByCssSelector('#modal')).toBeTruthy()
     |                                                             ^
  31 |     expect(await browser.eval('window.beforeNav')).toBe(1)
  32 |     expect(JSON.parse(await browser.elementByCss('#query').text())).toEqual({
  33 |       imageId: '123',

  at Object.toBeTruthy (integration/rewrites-manual-href-as/test/index.test.js:30:61)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/e2e/new-link-behavior/material-ui.test.ts (turbopack)

  • New Link Behavior with material-ui > should render MuiLink with
Expand output

● New Link Behavior with material-ui › should render MuiLink with 

Command failed with exit code 1 (EPERM): pnpm install --strict-peer-dependencies=false --no-frozen-lockfile --config.cacheDir=/tmp

  24 |   }
  25 |
> 26 |   await execa('pnpm', args, {
     |   ^
  27 |     cwd,
  28 |     stdio: ['ignore', 'inherit', 'inherit'],
  29 |     env: process.env,

  at makeError (../node_modules/.pnpm/execa@2.0.3/node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/.pnpm/execa@2.0.3/node_modules/execa/index.js:112:26)
  at installDependencies (lib/create-next-install.js:26:3)
  at Span.traceAsyncFn (../packages/next/src/trace/trace.ts:143:14)
  at lib/create-next-install.js:172:9
  at Span.traceAsyncFn (../packages/next/src/trace/trace.ts:143:14)
  at createNextInstall (lib/create-next-install.js:44:10)
  at lib/next-modes/base.ts:223:36
  at Span.traceAsyncFn (../packages/next/src/trace/trace.ts:143:14)
  at NextDevInstance.createTestDir (lib/next-modes/base.ts:150:5)
  at NextDevInstance.setup (lib/next-modes/next-dev.ts:17:5)
  at lib/e2e-utils/index.ts:201:7
  at Span.traceAsyncFn (../packages/next/src/trace/trace.ts:143:14)
  at createNext (lib/e2e-utils/index.ts:166:12)
  at Object.<anonymous> (lib/e2e-utils/index.ts:255:14)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/hydration-error.test.ts

  • Error overlay for hydration errors in App router > should only show one hydration error when bad nesting happened - p under p
Expand output

● Error overlay for hydration errors in App router › should only show one hydration error when bad nesting happened - p under p

expect(received).toBe(expected) // Object.is equality

Expected: 2
Received: 1

  567 |     await session.openRedbox()
  568 |
> 569 |     expect(await getRedboxTotalErrorCount(browser)).toBe(2)
      |                                                     ^
  570 |
  571 |     const description = await session.getRedboxDescription()
  572 |     expect(description).toContain(

  at Object.toBe (development/acceptance-app/hydration-error.test.ts:569:53)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/actions/app-action.test.ts (PPR)

  • app-dir action handling > should forward action request to a worker that contains the action handler (node)
Expand output

● app-dir action handling › should forward action request to a worker that contains the action handler (node)

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#other-page')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at e2e/app-dir/actions/app-action.test.ts:862:7

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Dec 10, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary JamBalaya56562/next.js turbopack Change
buildDuration 21.3s 19.6s N/A
buildDurationCached 18.6s 15.9s N/A
nodeModulesSize 410 MB 410 MB ⚠️ +132 B
nextStartRea..uration (ms) 532ms 536ms N/A
Client Bundles (main, webpack)
vercel/next.js canary JamBalaya56562/next.js turbopack Change
1187-HASH.js gzip 51.1 kB 51.1 kB ✓
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 51.1 kB 51.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary JamBalaya56562/next.js turbopack Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary JamBalaya56562/next.js turbopack Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary JamBalaya56562/next.js turbopack Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary JamBalaya56562/next.js turbopack Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary JamBalaya56562/next.js turbopack Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary JamBalaya56562/next.js turbopack Change
middleware-b..fest.js gzip 672 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary JamBalaya56562/next.js turbopack Change
523-experime...dev.js gzip 322 B 322 B ✓
523.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 323 kB 323 kB ✓
app-page-exp..prod.js gzip 127 kB 127 kB ✓
app-page-tur..prod.js gzip 140 kB 140 kB ✓
app-page-tur..prod.js gzip 135 kB 135 kB ✓
app-page.run...dev.js gzip 314 kB 314 kB ✓
app-page.run..prod.js gzip 123 kB 123 kB ✓
app-route-ex...dev.js gzip 37.4 kB 37.4 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.3 kB 25.3 kB ✓
app-route.ru...dev.js gzip 39 kB 39 kB ✓
app-route.ru..prod.js gzip 25.3 kB 25.3 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.4 kB 27.4 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.36 MB 2.36 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary JamBalaya56562/next.js turbopack Change
0.pack gzip 2.06 MB 2.07 MB ⚠️ +507 B
index.pack gzip 73.4 kB 73.3 kB N/A
Overall change 2.06 MB 2.07 MB ⚠️ +507 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 3589c5b

@JamBalaya56562
Copy link
Contributor Author

Thank you for checking this PR!
I have tested some failed tests, but it worked on my local PC.
Could you rerun CI?

@samcx samcx enabled auto-merge (squash) December 17, 2024 01:46
@samcx samcx merged commit 5a24406 into vercel:canary Dec 17, 2024
103 checks passed
@JamBalaya56562 JamBalaya56562 deleted the turbopack branch December 17, 2024 02:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samcx samcx samcx approved these changes

Assignees
No one assigned
Labels
locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamBalaya56562 @ijjk @samcx