Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust version #73169

Merged
merged 10 commits into from
Dec 12, 2024
Merged

Bump Rust version #73169

merged 10 commits into from
Dec 12, 2024

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Nov 25, 2024

We should try to wait for napi-rs/napi-rs#2370 to fix a lot of these warnings:

warning: unexpected `cfg` condition value: `noop`
  --> crates/napi/src/mdx.rs:25:1
   |
25 | #[napi]
   | ^^^^^^^
   |
   = note: expected values for `feature` are: `__internal_dhat-ad-hoc`, `__internal_dhat-heap`, `dhat`, `image-avif`, `image-extended`, `image-webp`, `plugin`, and `turbopack-ecmascript-plugins`
   = help: consider adding `noop` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: `#[warn(unexpected_cfgs)]` on by default
   = note: this warning originates in the attribute macro `napi` (in Nightly builds, run with -Z macro-backtrace for more info)

Closes PACK-3645

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Nov 25, 2024
@ijjk
Copy link
Member

ijjk commented Nov 25, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Nov 25, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
buildDuration 18.1s 15.6s N/A
buildDurationCached 14.8s 12.5s N/A
nodeModulesSize 409 MB 409 MB
nextStartRea..uration (ms) 473ms 471ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
1187-HASH.js gzip 50.8 kB 50.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
_buildManifest.js gzip 747 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
index.html gzip 524 B 522 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 313 kB 313 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.3 kB 37.3 kB
app-route-ex..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.2 kB 25.2 kB
app-route.ru...dev.js gzip 38.9 kB 38.9 kB
app-route.ru..prod.js gzip 25.2 kB 25.2 kB
pages-api-tu..prod.js gzip 9.67 kB 9.67 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.66 kB 9.66 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mischnic/upgrade-rust Change
0.pack gzip 2.05 MB 2.05 MB N/A
index.pack gzip 71.7 kB 72.4 kB ⚠️ +643 B
Overall change 71.7 kB 72.4 kB ⚠️ +643 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: d6b57fc

@Brooooooklyn
Copy link
Contributor

@mischnic
Copy link
Contributor Author

mischnic commented Dec 4, 2024

@Brooooooklyn Great, thank you!

@mischnic mischnic force-pushed the mischnic/upgrade-rust branch from 3f6e4ef to 81aa968 Compare December 4, 2024 10:25
@mischnic mischnic marked this pull request as ready for review December 4, 2024 11:01
@mischnic mischnic force-pushed the mischnic/upgrade-rust branch from 1c9cf31 to 06efaef Compare December 6, 2024 10:18
@mischnic mischnic force-pushed the mischnic/upgrade-rust branch from 06efaef to b3e9c3c Compare December 11, 2024 20:04
@mischnic mischnic force-pushed the mischnic/upgrade-rust branch from b3e9c3c to d6b57fc Compare December 12, 2024 09:25
@mischnic mischnic merged commit 477e1e4 into canary Dec 12, 2024
108 of 111 checks passed
@mischnic mischnic deleted the mischnic/upgrade-rust branch December 12, 2024 10:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants