Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hoist a server function if a compile error was emitted #73189

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Don't hoist a server function if a compile error was emitted #73189

merged 4 commits into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. Don't hoist a server function if a compile error was emitted 

    This allows us to skip unnecessary work, and also avoids generating
invalid code, e.g. not allowed `super` calls in hoisted methods.
    @unstubbable
    unstubbable committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    025bb9d View commit details
    Browse the repository at this point in the history

  2. Make child_names handling more readable

    @unstubbable
    unstubbable committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    421f967 View commit details
    Browse the repository at this point in the history

  3. Also don't hoist arrow expressions with errors

    @unstubbable
    unstubbable committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ac9c4e7 View commit details
    Browse the repository at this point in the history

  4. Return early if server function is not async

    @unstubbable
    unstubbable committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    6eaae79 View commit details
    Browse the repository at this point in the history