Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update turbopack-dev-examples-manifest #73230

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Nov 27, 2024

Summary

At #73211, with-unstated example was deleted.
In addition, at #73243 with-react-foundation example was removed.
So, I also remove them from turbopack-dev-examples-manifest.

CC: @samcx

@ijjk ijjk added the tests label Nov 27, 2024
@ijjk
Copy link
Member

ijjk commented Nov 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: 7b6490d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: e629d53

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@JamBalaya56562 JamBalaya56562 force-pushed the unstated branch 3 times, most recently from 2ed8ee3 to bad0c30 Compare December 3, 2024 23:49
@JamBalaya56562 JamBalaya56562 force-pushed the unstated branch 2 times, most recently from 0599bcf to 0f16dac Compare December 9, 2024 01:34
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the assist!

:lgtm:

@samcx samcx enabled auto-merge (squash) December 10, 2024 06:20
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Failing test suites

Commit: df3b24c

pnpm test-dev test/development/acceptance/server-component-compiler-errors-in-pages.test.ts

  • Error Overlay for server components compiler errors in pages > importing after from 'next/server' in pages
Expand output

● Error Overlay for server components compiler errors in pages › importing after from 'next/server' in pages

Expected Redbox but found none

  159 |     )
  160 |
> 161 |     await session.assertHasRedbox()
      |     ^
  162 |     await expect(session.getRedboxSource()).resolves.toMatch(
  163 |       /That only works in a Server Component/
  164 |     )

  at Object.<anonymous> (development/acceptance/server-component-compiler-errors-in-pages.test.ts:161:5)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/build-warnings/test/index.test.js (turbopack)

  • Build warnings > production mode > should warn about missing cache in CI
Expand output

● Build warnings › production mode › should warn about missing cache in CI

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  84 |       })
  85 |
> 86 |       it('should warn about missing cache in CI', async () => {
     |       ^
  87 |         await remove(join(appDir, '.next'))
  88 |
  89 |         let { stdout } = await nextBuild(appDir, undefined, {

  at it (integration/build-warnings/test/index.test.js:86:7)
  at integration/build-warnings/test/index.test.js:10:56
  at Object.describe (integration/build-warnings/test/index.test.js:9:1)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary JamBalaya56562/next.js unstated Change
buildDuration 38s 35.4s N/A
buildDurationCached 34.2s 31.1s N/A
nodeModulesSize 409 MB 409 MB
nextStartRea..uration (ms) 851ms 846ms N/A
Client Bundles (main, webpack)
vercel/next.js canary JamBalaya56562/next.js unstated Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary JamBalaya56562/next.js unstated Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary JamBalaya56562/next.js unstated Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary JamBalaya56562/next.js unstated Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary JamBalaya56562/next.js unstated Change
index.html gzip 524 B 523 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 520 B 520 B
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary JamBalaya56562/next.js unstated Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary JamBalaya56562/next.js unstated Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary JamBalaya56562/next.js unstated Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 122 kB 122 kB
app-route-ex...dev.js gzip 37.1 kB 37.1 kB
app-route-ex..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 24.9 kB 24.9 kB
app-route.ru...dev.js gzip 38.7 kB 38.7 kB
app-route.ru..prod.js gzip 24.9 kB 24.9 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.35 MB 2.35 MB
build cache Overall increase ⚠️
vercel/next.js canary JamBalaya56562/next.js unstated Change
0.pack gzip 2.04 MB 2.04 MB ⚠️ +9.27 kB
index.pack gzip 146 kB 146 kB N/A
Overall change 2.04 MB 2.04 MB ⚠️ +9.27 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: df3b24c

@samcx samcx merged commit 58f9df3 into vercel:canary Dec 10, 2024
86 checks passed
@JamBalaya56562 JamBalaya56562 deleted the unstated branch December 10, 2024 06:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants