Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbopack): Use ResolvedVc<T> for struct fields in turbopack-css #73300

Merged
merged 14 commits into from
Nov 30, 2024
Merged

refactor(turbopack): Use ResolvedVc<T> for struct fields in turbopack-css #73300

merged 14 commits into from
Nov 30, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 28, 2024 •
edited by padmaia
Loading

Closes PACK-3583

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Nov 28, 2024
@kdy1 Graphite App
Copy link
Member Author

kdy1 commented Nov 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 28, 2024
Merged
Closed
Merged
Merged
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from f988a91 to abac5d2 Compare November 28, 2024 06:07
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-next-api to kdy1/resolved-vc-turbopack-ecmascript November 28, 2024 06:07
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from 089d4ff to 6c2777e Compare November 28, 2024 06:31
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from abac5d2 to df70628 Compare November 28, 2024 06:31
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from 6c2777e to df3c600 Compare November 28, 2024 07:11
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from df70628 to 0e4d3b9 Compare November 28, 2024 07:11
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from df3c600 to a307f96 Compare November 28, 2024 07:18
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 0e4d3b9 to eede930 Compare November 28, 2024 07:18
@kdy1 kdy1 mentioned this pull request Nov 28, 2024
Merged
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from a307f96 to cbf5304 Compare November 28, 2024 07:27
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from eede930 to 2e80487 Compare November 28, 2024 07:27
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from cbf5304 to 412cc57 Compare November 28, 2024 08:44
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 2e80487 to 735d870 Compare November 28, 2024 08:44
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from 412cc57 to 5959f01 Compare November 28, 2024 09:04
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch 2 times, most recently from 1d3b627 to 579c55d Compare November 28, 2024 09:13
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from 83aa4c5 to d438784 Compare November 28, 2024 10:39
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 579c55d to 47ff248 Compare November 28, 2024 10:39
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from d438784 to ffb497b Compare November 29, 2024 17:20
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 47ff248 to c6f9c94 Compare November 29, 2024 17:20
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from ffb497b to 7554a5f Compare November 29, 2024 17:22
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch 2 times, most recently from 4092bbe to 8877b8b Compare November 29, 2024 17:40
@kdy1 kdy1 changed the title turbopack-css: ResolvedVc<T> refactor(turbopack): Use ResolvedVc<T> for struct fields in turbopack-css Nov 29, 2024
@kdy1 kdy1 mentioned this pull request Nov 29, 2024
Merged
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-turbopack-ecmascript to graphite-base/73300 November 29, 2024 23:51
@kdy1 kdy1 force-pushed the graphite-base/73300 branch from c6bdd1a to e06bb4b Compare November 29, 2024 23:52
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 162bc4e to 48c5cf8 Compare November 29, 2024 23:52
@kdy1 kdy1 changed the base branch from graphite-base/73300 to canary November 29, 2024 23:52
@kdy1 @mischnic
Update turbopack/crates/turbopack-css/src/references/mod.rs
739329a 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 48c5cf8 to 739329a Compare November 29, 2024 23:52
@ijjk
Copy link
Member

ijjk commented Nov 29, 2024 •
edited
Loading

Tests Passed

This was referenced Nov 30, 2024
Merged
Merged
@kdy1 kdy1 merged commit 4509546 into canary Nov 30, 2024
114 of 115 checks passed
@kdy1 Graphite App
Copy link
Member Author

kdy1 commented Nov 30, 2024

Merge activity

  • Nov 30, 11:19 AM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/resolved-vc-turbopack-css branch November 30, 2024 02:19
@kdy1 kdy1 mentioned this pull request Dec 3, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
@kdy1 kdy1 self-assigned this Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mischnic mischnic mischnic approved these changes

@bgw bgw Awaiting requested review from bgw

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdy1 @ijjk @mischnic