Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: fix view source pathname at image-legacy-component #73414

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Dec 2, 2024

Description

#73344 updates the image-legacy-component example for using the App Router.
However, ViewSource component isn't updated.
Then I update the pathname.

CC: @samcx

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 2, 2024
@ijjk
Copy link
Member

ijjk commented Dec 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4460934

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Dec 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: b565225

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@JamBalaya56562 JamBalaya56562 force-pushed the image branch 3 times, most recently from a55418d to b565225 Compare December 9, 2024 01:29
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the assist!

:lgtm:

@samcx samcx enabled auto-merge (squash) December 10, 2024 06:24
@samcx samcx merged commit 9a14f58 into vercel:canary Dec 10, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the image branch December 10, 2024 06:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants