Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] cleanup and documentation #73496

Merged
merged 6 commits into from
Dec 10, 2024
Merged

[Turbopack] cleanup and documentation #73496

merged 6 commits into from
Dec 10, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 4, 2024

What?

  • avoid flagging "thread" span as incomplete
  • improve error message
  • add comments
  • fixup print_stats
  • fix lmdb feature

Closes PACK-3634

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Dec 4, 2024
Copy link
Member Author

sokra commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra changed the title avoid flagging "thread" span as incomplete [Turbopack] cleanup and documentation Dec 4, 2024
@ijjk
Copy link
Member

ijjk commented Dec 4, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
buildDuration 21.1s 21.8s ⚠️ +666ms
buildDurationCached 18s 15.6s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 489ms 489ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
1187-HASH.js gzip 50.2 kB 49.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.75 kB 1.75 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
_buildManifest.js gzip 746 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
index.html gzip 523 B 524 B N/A
link.html gzip 536 B 537 B N/A
withRouter.html gzip 518 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 200 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
middleware-b..fest.js gzip 667 B 663 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31.1 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
797-experime...dev.js gzip 322 B 322 B
797.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 321 kB N/A
app-page-exp..prod.js gzip 127 kB 126 kB N/A
app-page-tur..prod.js gzip 140 kB 139 kB N/A
app-page-tur..prod.js gzip 135 kB 134 kB N/A
app-page.run...dev.js gzip 312 kB 311 kB N/A
app-page.run..prod.js gzip 122 kB 122 kB N/A
app-route-ex...dev.js gzip 37.1 kB 36.8 kB N/A
app-route-ex..prod.js gzip 25.1 kB 25 kB N/A
app-route-tu..prod.js gzip 25.1 kB 25 kB N/A
app-route-tu..prod.js gzip 24.9 kB 24.8 kB N/A
app-route.ru...dev.js gzip 38.7 kB 38.5 kB N/A
app-route.ru..prod.js gzip 24.9 kB 24.8 kB N/A
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 101 kB 101 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/cleanup-fixes Change
0.pack gzip 2.04 MB 2.03 MB N/A
index.pack gzip 144 kB 146 kB ⚠️ +1.81 kB
Overall change 144 kB 146 kB ⚠️ +1.81 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 2c331c1

@sokra sokra requested a review from mischnic December 4, 2024 07:00
@sokra sokra marked this pull request as ready for review December 4, 2024 07:00
@sokra sokra force-pushed the sokra/cleanup-fixes branch from 3ff80ec to 70e9aa5 Compare December 6, 2024 09:10
@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Tests Passed

@sokra sokra merged commit 778ee4f into canary Dec 10, 2024
112 checks passed
Copy link
Member Author

sokra commented Dec 10, 2024

Merge activity

  • Dec 10, 7:43 AM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/cleanup-fixes branch December 10, 2024 12:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants