Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js Image Component: Width/Height Update #73509

Open
wants to merge 18 commits into
base: canary
Choose a base branch
from

Conversation

KeazoN
Copy link

@KeazoN KeazoN commented Dec 4, 2024

This PR addresses an issue with the Next.js Image component where the width and height attributes were marked as optional but caused errors when omitted. These attributes are now required to ensure consistent behavior and prevent runtime errors.

This update improves the developer experience and ensures reliable implementation of the Image component.

  • Resolved an issue where optional width and height attributes caused errors when omitted.
  • Updated the implementation to enforce these attributes as required for consistency and reliability.

@ijjk ijjk added the type: next label Dec 4, 2024
@sannajammeh
Copy link
Contributor

What about fill mode?

Copy link

@youneshenniwrites youneshenniwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@KeazoN
Copy link
Author

KeazoN commented Dec 21, 2024

Isn't anyone interested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants