Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable @types/react #73563

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 5, 2024

Also updated docs now that we no longer need these weird npm:types-react aliases.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. type: next labels Dec 5, 2024
Copy link
Member Author

eps1lon commented Dec 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eps1lon eps1lon requested a review from huozhi December 5, 2024 19:39
@eps1lon eps1lon force-pushed the sebbie/12-05-use_stable_types/react_ branch from d9cb69c to bb82e26 Compare December 5, 2024 19:42
@eps1lon eps1lon marked this pull request as ready for review December 5, 2024 19:43
@ijjk
Copy link
Member

ijjk commented Dec 5, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 5, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
buildDuration 19.6s 17.6s N/A
buildDurationCached 16.7s 14.4s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 454ms 454ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
1187-HASH.js gzip 49.2 kB 49.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.7 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.75 kB 1.75 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
_buildManifest.js gzip 746 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
index.html gzip 524 B 523 B N/A
link.html gzip 537 B 536 B N/A
withRouter.html gzip 519 B 519 B
Overall change 519 B 519 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 200 kB 200 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
middleware-b..fest.js gzip 666 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.1 kB 31.1 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
797-experime...dev.js gzip 322 B 322 B
797.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 321 kB 321 kB
app-page-exp..prod.js gzip 126 kB 126 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page-tur..prod.js gzip 134 kB 134 kB
app-page.run...dev.js gzip 311 kB 311 kB N/A
app-page.run..prod.js gzip 122 kB 122 kB
app-route-ex...dev.js gzip 36.8 kB 36.8 kB
app-route-ex..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 24.8 kB 24.8 kB
app-route.ru...dev.js gzip 38.5 kB 38.5 kB
app-route.ru..prod.js gzip 24.8 kB 24.8 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.03 MB 2.03 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/12-05-use_stable_types/react_ Change
0.pack gzip 2.03 MB 2.04 MB ⚠️ +9.74 kB
index.pack gzip 145 kB 146 kB ⚠️ +1.56 kB
Overall change 2.18 MB 2.19 MB ⚠️ +11.3 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: bb82e26

Copy link

socket-security bot commented Dec 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/types-react-dom@19.0.0-rc.0, npm/types-react@19.0.0-rc.0

View full report↗︎

Base automatically changed from sebbie/12-04-use_react_19_stable to canary December 5, 2024 20:19
@eps1lon eps1lon force-pushed the sebbie/12-05-use_stable_types/react_ branch from bb82e26 to ff95a32 Compare December 5, 2024 20:20
@eps1lon eps1lon merged commit 550f4a8 into canary Dec 5, 2024
106 of 112 checks passed
Copy link
Member Author

eps1lon commented Dec 5, 2024

Merge activity

  • Dec 5, 9:45 PM GMT+1: A user merged this pull request with Graphite.

@eps1lon eps1lon deleted the sebbie/12-05-use_stable_types/react_ branch December 5, 2024 20:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants