Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: convert @next/third-parties examples from JS to TS #73602

Merged
merged 9 commits into from
Dec 17, 2024

Conversation

suu3
Copy link
Contributor

@suu3 suu3 commented Dec 6, 2024

What?

  • with-google-maps-embed example
  • with-google-tag-manager example
  • with-youtube-embed example

Why?

The examples are written in JavaScript.

How?

Converted JavaScript examples to TypeScript.

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 6, 2024
@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: b37a40d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@suu3 suu3 force-pushed the examples-third-parties branch from 91500cb to fbcc734 Compare December 10, 2024 00:07
@suu3 suu3 force-pushed the examples-third-parties branch from fbcc734 to b37a40d Compare December 16, 2024 17:45
@samcx samcx self-requested a review December 17, 2024 00:39
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit 6a609fa into vercel:canary Dec 17, 2024
39 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants