feat(after): stabilize `unstable_after` #73605

lubieowoce · 2024-12-06T15:52:36Z

rename unstable_after -> after
remove experimental.after flag (and warn if it's present)

i separated the big find-and-replace into a separate commit so that it's easier to see what else changed apart from that.

does not touch docs, that's in #73038

docs/01-app/03-api-reference/04-functions/after.mdx

ijjk · 2024-12-06T16:02:12Z

Tests Passed

ijjk · 2024-12-06T16:11:21Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
buildDuration	21s	17.3s	N/A
buildDurationCached	16.7s	14.5s	N/A
nodeModulesSize	409 MB	409 MB	N/A
nextStartRea..uration (ms)	476ms	466ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
1187-HASH.js gzip	50.1 kB	50.1 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.3 kB	5.3 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	232 B	235 B	N/A
main-HASH.js gzip	33.7 kB	33.7 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.44 kB	4.43 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	1.75 kB	1.75 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
_buildManifest.js gzip	746 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
index.html gzip	523 B	524 B	N/A
link.html gzip	537 B	537 B	✓
withRouter.html gzip	519 B	521 B	N/A
Overall change	537 B	537 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	202 kB	202 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
middleware-b..fest.js gzip	665 B	664 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.1 kB	31 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
797-experime...dev.js gzip	322 B	322 B	✓
797.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	322 kB	322 kB	N/A
app-page-exp..prod.js gzip	126 kB	126 kB	N/A
app-page-tur..prod.js gzip	139 kB	139 kB	N/A
app-page-tur..prod.js gzip	135 kB	134 kB	N/A
app-page.run...dev.js gzip	312 kB	312 kB	N/A
app-page.run..prod.js gzip	122 kB	122 kB	N/A
app-route-ex...dev.js gzip	36.8 kB	36.8 kB	N/A
app-route-ex..prod.js gzip	25 kB	25 kB	N/A
app-route-tu..prod.js gzip	25 kB	25 kB	N/A
app-route-tu..prod.js gzip	24.8 kB	24.8 kB	N/A
app-route.ru...dev.js gzip	38.5 kB	38.4 kB	N/A
app-route.ru..prod.js gzip	24.8 kB	24.8 kB	N/A
pages-api-tu..prod.js gzip	9.56 kB	9.56 kB	✓
pages-api.ru...dev.js gzip	11.4 kB	11.4 kB	✓
pages-api.ru..prod.js gzip	9.56 kB	9.56 kB	✓
pages-turbo...prod.js gzip	21.3 kB	21.3 kB	✓
pages.runtim...dev.js gzip	27 kB	27 kB	✓
pages.runtim..prod.js gzip	21.3 kB	21.3 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	N/A
Overall change	101 kB	101 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js lubieowoce/stabilize-after	Change
0.pack gzip	2.04 MB	2.03 MB	N/A
index.pack gzip	145 kB	145 kB	⚠️ +458 B
Overall change	145 kB	145 kB	⚠️ +458 B

Diff details

Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 2476cce

vercel · 2024-12-06T16:50:00Z

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

lubieowoce · 2024-12-06T16:53:42Z

packages/next/src/server/config.ts

@@ -453,7 +453,14 @@ function assignDefaults(
  warnOptionHasBeenDeprecated(
    result,
    'experimental.instrumentationHook',
-    '`experimental.instrumentationHook` is no longer needed to be configured in Next.js',
+    `\`experimental.instrumentationHook\` is not longer needed, because \`instrumentation.js\` is available by default. You can remove it from ${configFileName}.`,


rephrased this a bit while i was here, sounds a bit more natural to me

lubieowoce · 2024-12-06T19:05:49Z

feat(after): stitched stack traces #73593 : 2 dependent PRs (#73449 , #73601 )
feat(after): stabilize unstable_after #73605 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

**Do not merge until stable `after` lands in canary (#73605).** Closes: https://linear.app/vercel/issue/DOC-3818/[stable]-nextafter Redirect: vercel/front#38704 --------- Co-authored-by: Lee Robinson <me@leerob.io>

ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. tests Turbopack Related to Turbopack with Next.js. type: next labels Dec 6, 2024

lubieowoce commented Dec 6, 2024

View reviewed changes

docs/01-app/03-api-reference/04-functions/after.mdx Outdated Show resolved Hide resolved

lubieowoce force-pushed the lubieowoce/stabilize-after branch from ec35d86 to 1bac9fe Compare December 6, 2024 15:59

lubieowoce mentioned this pull request Dec 6, 2024

15.1 docs: stable after #73038

Merged

lubieowoce force-pushed the lubieowoce/stabilize-after branch 2 times, most recently from 4db233e to aff12ad Compare December 6, 2024 16:22

lubieowoce marked this pull request as ready for review December 6, 2024 16:25

lubieowoce force-pushed the lubieowoce/stabilize-after branch from aff12ad to 6aa5c46 Compare December 6, 2024 16:29

lubieowoce commented Dec 6, 2024

View reviewed changes

lubieowoce force-pushed the lubieowoce/stabilize-after branch from 9a50748 to e969a8a Compare December 6, 2024 16:54

ztanner approved these changes Dec 6, 2024

View reviewed changes

lubieowoce enabled auto-merge (squash) December 6, 2024 17:39

lubieowoce added 4 commits December 6, 2024 19:31

remove the "experimental.after" flag

c52ab7a

rename "unstable_after" -> "after"

fb3bb16

remove "when after becomes stablle" comments

f9ffa5a

warn about "experimental.after" in next.config.js

2476cce

lubieowoce force-pushed the lubieowoce/stabilize-after branch from e969a8a to 2476cce Compare December 6, 2024 18:31

This was referenced Dec 6, 2024

feat(after): surface after errors in error overlay #73449

Draft

feat(after): stitched stack traces #73593

Draft

lubieowoce mentioned this pull request Dec 6, 2024

switchable placeholder/promise behavior #73601

Closed

ijjk approved these changes Dec 6, 2024

View reviewed changes

lubieowoce merged commit 82e84e4 into canary Dec 6, 2024
108 of 113 checks passed

lubieowoce deleted the lubieowoce/stabilize-after branch December 6, 2024 19:59

github-actions bot added the locked label Dec 21, 2024

github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(after): stabilize `unstable_after` #73605

feat(after): stabilize `unstable_after` #73605

lubieowoce commented Dec 6, 2024 •

edited

Loading

ijjk commented Dec 6, 2024 •

edited

Loading

ijjk commented Dec 6, 2024 •

edited

Loading

vercel bot commented Dec 6, 2024 •

edited

Loading

lubieowoce Dec 6, 2024

lubieowoce commented Dec 6, 2024 •

edited

Loading

feat(after): stabilize unstable_after #73605

feat(after): stabilize unstable_after #73605

Conversation

lubieowoce commented Dec 6, 2024 • edited Loading

ijjk commented Dec 6, 2024 • edited Loading

Tests Passed

ijjk commented Dec 6, 2024 • edited Loading

Stats from current PR

vercel bot commented Dec 6, 2024 • edited Loading

lubieowoce Dec 6, 2024

Choose a reason for hiding this comment

lubieowoce commented Dec 6, 2024 • edited Loading

feat(after): stabilize `unstable_after` #73605

feat(after): stabilize `unstable_after` #73605

lubieowoce commented Dec 6, 2024 •

edited

Loading

ijjk commented Dec 6, 2024 •

edited

Loading

ijjk commented Dec 6, 2024 •

edited

Loading

vercel bot commented Dec 6, 2024 •

edited

Loading

lubieowoce commented Dec 6, 2024 •

edited

Loading