Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: remove next-offline example #73675

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

JamBalaya56562
Copy link
Contributor

What?

Remove next-offline example.

Why?

next-offline package hasn't been maintained in 3 years.

Adding or Updating Examples

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 9, 2024
@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Allow CI Workflow Run

  • approve CI run for commit: a935418

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx self-requested a review December 9, 2024 19:16
@samcx
Copy link
Member

samcx commented Dec 9, 2024

@JamBalaya56562 We can try creating a new example as a follow-up that follows this → https://nextjs.org/docs/app/building-your-application/configuring/progressive-web-apps!

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit b255108 into vercel:canary Dec 9, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the next-offline branch December 9, 2024 23:39
@JamBalaya56562
Copy link
Contributor Author

@JamBalaya56562 We can try creating a new example as a follow-up that follows this → https://nextjs.org/docs/app/building-your-application/configuring/progressive-web-apps!

Sounds nice!
To be honest, it might be good to update the existing pregressive-web-app example.

@samcx
Copy link
Member

samcx commented Dec 10, 2024

@JamBalaya56562 That sounds good to me!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants