Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prefetching lazily generated param #73715

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

acdlite
Copy link
Contributor

@acdlite acdlite commented Dec 10, 2024

Fixes an oversight in #72168 where the segment data was not correctly transferred from the render result to the cache entry in the case where a prerender is lazily generated after build.

I also took the opportunity to remove one of the intermediate types used by the various layers that the segment data passes through. For some reason, in the original PR I made the type of segmentData on CachedAppPageValue an object while the corresponding type on AppPageRenderResultMetadata was a map. (I didn't really notice before because in the case where the entry is generated at build time, it gets written to disk then read back out, so there's some data conversion happening anyway.)

@acdlite acdlite requested a review from ijjk December 10, 2024 02:01
Fixes an oversight in vercel#72168 where the segment data was not correctly
transferred from the render result to the cache entry in the case where
a prerender is lazily generated after build.

I also took the opportunity to remove one of the intermediate types
used by the various layers that the segment data passes through. For
some reason, in the original PR I made the type of `segmentData` on
CachedAppPageValue an object while the corresponding type on
AppPageRenderResultMetadata was a map. (I didn't really notice before
because in the case where the entry is generated at built time, it gets
written to disk then read back out, so there's some data conversion
happening anyway.)
@acdlite acdlite force-pushed the fix-prefetching-lazy-param branch from a3c5538 to 5d4df5d Compare December 10, 2024 02:13
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
buildDuration 20.4s 20.5s N/A
buildDurationCached 16.7s 14.5s N/A
nodeModulesSize 409 MB 409 MB ⚠️ +509 kB
nextStartRea..uration (ms) 473ms 475ms N/A
Client Bundles (main, webpack)
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 511 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.75 kB 1.75 kB
Client Build Manifests
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
_buildManifest.js gzip 747 B 747 B
Overall change 747 B 747 B
Rendered Page Sizes
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
index.html gzip 524 B 522 B N/A
link.html gzip 538 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
middleware-b..fest.js gzip 671 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB N/A
app-page-exp..prod.js gzip 127 kB 127 kB N/A
app-page-tur..prod.js gzip 140 kB 140 kB N/A
app-page-tur..prod.js gzip 135 kB 135 kB N/A
app-page.run...dev.js gzip 312 kB 312 kB N/A
app-page.run..prod.js gzip 122 kB 122 kB N/A
app-route-ex...dev.js gzip 37.1 kB 37.1 kB N/A
app-route-ex..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 24.9 kB 24.9 kB
app-route.ru...dev.js gzip 38.7 kB 38.7 kB N/A
app-route.ru..prod.js gzip 24.9 kB 24.9 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 201 kB 201 kB
build cache Overall increase ⚠️
vercel/next.js canary acdlite/next.js fix-prefetching-lazy-param Change
0.pack gzip 2.04 MB 2.04 MB ⚠️ +1.13 kB
index.pack gzip 145 kB 146 kB ⚠️ +1.17 kB
Overall change 2.18 MB 2.18 MB ⚠️ +2.3 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js
failed to diff
Commit: 5d4df5d

@acdlite acdlite requested a review from ztanner December 10, 2024 02:34
@acdlite acdlite enabled auto-merge (squash) December 10, 2024 03:19
@acdlite acdlite merged commit 3eb1d03 into vercel:canary Dec 10, 2024
86 checks passed
acdlite added a commit that referenced this pull request Dec 12, 2024
Follow-up to #73715. Since PPR should always result in a cache hit for a
prefetch (even in the worst case, there's a fallback cache entry), the
only reason a route tree prefetch would not be found in the per-segment
cache is because PPR is disabled.

So we should just fallthrough to the old prefetching flow whenever PPR
is disabled.

But the client still needs some way to tell whether the response was
served from the per-segment cache or by the old implementation.

So I added an explicit response header to every per-segment prefetch. If
the header is missing, the client can infer that the route does not
support PPR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants