Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: update with-styled-components README #73729

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Dec 10, 2024

What?

Delete Notes on next/link in the with-styled-components example.

Why?

as prop of next/link is no longer required at v10.0.0 Next.js.

Therefore, the as prop provided by styled doesn't collide with the next/Link's as prop.

CC: @samcx

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 10, 2024
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Allow CI Workflow Run

  • approve CI run for commit: 1aaf8fd

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@JamBalaya56562 JamBalaya56562 force-pushed the styled branch 4 times, most recently from 4a3f0bc to 9426ac9 Compare December 13, 2024 18:59
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit d0e4aa0 into vercel:canary Dec 17, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the styled branch December 17, 2024 01:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants