-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test retries from 1 to 2 #73795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
Let's see how this affects the failure rate and duration of our tests in CI. Test times for any given group might increase a bit, while hopefully at least increasing the chance that the whole test group succeeds. This would in theory reduce the number of times we have to re-run a whole failed test group, which is quite time consuming. A possible downside of this change is that flaky tests which have a chance of getting fixed with a better implementation might be harder to detect.
unstubbable
force-pushed
the
hl/increase-retry-count
branch
from
December 11, 2024 13:12
f2a42ce
to
86664cd
Compare
gaojude
approved these changes
Dec 11, 2024
ijjk
approved these changes
Dec 11, 2024
lubieowoce
approved these changes
Dec 11, 2024
bgw
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see how this affects the failure rate and duration of our tests in CI.
Test times for any given group might increase a bit, while hopefully at least increasing the chance that the whole test group succeeds. This would in theory reduce the number of times we have to re-run a whole failed test group, which is quite time consuming.
A possible downside of this change is that flaky tests which have a chance of getting fixed with a better implementation might be harder to detect.