Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional error classes and error codes #73862

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add additional error classes and error codes #73862

merged 1 commit into from
Dec 13, 2024
+129 −3

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Dec 12, 2024 •
edited
Loading

Adds support for additional error classes in the error code SWC plugin.

Follow up for #73332 (comment)

@gaojude gaojude requested a review from eps1lon December 12, 2024 19:19
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Turbopack Related to Turbopack with Next.js. type: next labels Dec 12, 2024
@gaojude gaojude requested a review from devjiwonchoi December 12, 2024 19:19
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/more-error-classes Change
buildDuration 17.9s 16.3s N/A
buildDurationCached 15.3s 13.1s N/A
nodeModulesSize 410 MB 410 MB ⚠️ +163 kB
nextStartRea..uration (ms) 488ms 485ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js jude/more-error-classes Change
1187-HASH.js gzip 50.8 kB 50.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js jude/more-error-classes Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js jude/more-error-classes Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js jude/more-error-classes Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js jude/more-error-classes Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 520 B 520 B ✓
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/more-error-classes Change
edge-ssr.js gzip 128 kB 128 kB ⚠️ +111 B
page.js gzip 203 kB 204 kB ⚠️ +309 B
Overall change 332 kB 332 kB ⚠️ +420 B
Middleware size
vercel/next.js canary vercel/next.js jude/more-error-classes Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/more-error-classes Change
523-experime...dev.js gzip 322 B 322 B ✓
523.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 323 kB 323 kB ⚠️ +268 B
app-page-exp..prod.js gzip 127 kB 127 kB ⚠️ +172 B
app-page-tur..prod.js gzip 140 kB 140 kB ⚠️ +164 B
app-page-tur..prod.js gzip 135 kB 135 kB ⚠️ +159 B
app-page.run...dev.js gzip 313 kB 313 kB ⚠️ +268 B
app-page.run..prod.js gzip 123 kB 123 kB ⚠️ +168 B
app-route-ex...dev.js gzip 37.3 kB 37.4 kB ⚠️ +111 B
app-route-ex..prod.js gzip 25.3 kB 25.5 kB ⚠️ +104 B
app-route-tu..prod.js gzip 25.4 kB 25.5 kB ⚠️ +104 B
app-route-tu..prod.js gzip 25.2 kB 25.3 kB ⚠️ +106 B
app-route.ru...dev.js gzip 38.9 kB 39 kB ⚠️ +105 B
app-route.ru..prod.js gzip 25.2 kB 25.3 kB ⚠️ +106 B
pages-api-tu..prod.js gzip 9.67 kB 9.69 kB N/A
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB N/A
pages-api.ru..prod.js gzip 9.67 kB 9.68 kB N/A
pages-turbo...prod.js gzip 21.7 kB 21.7 kB N/A
pages.runtim...dev.js gzip 27.4 kB 27.4 kB N/A
pages.runtim..prod.js gzip 21.7 kB 21.7 kB N/A
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 1.34 MB 1.34 MB ⚠️ +1.83 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/more-error-classes Change
0.pack gzip 2.05 MB 2.05 MB ⚠️ +2.81 kB
index.pack gzip 70.9 kB 72 kB ⚠️ +1.09 kB
Overall change 2.12 MB 2.13 MB ⚠️ +3.9 kB
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for pages-api-tu..time.prod.js

Diff too large to display

Diff for pages-api.runtime.dev.js

Diff too large to display

Diff for pages-api.ru..time.prod.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Diff for pages.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: a56c0aa

@gaojude gaojude force-pushed the jude/more-error-classes branch from a8a668f to fa50fbd Compare December 12, 2024 21:25
@gaojude Graphite App
Copy link
Contributor Author

gaojude commented Dec 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 12, 2024
Merged
Merged
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024 •
edited
Loading

Tests Passed

@gaojude gaojude changed the title Complete error code coverage Add error classes and error codes Dec 12, 2024
@gaojude gaojude changed the title Add error classes and error codes Add additional error classes and error codes Dec 12, 2024
@gaojude gaojude force-pushed the jude/more-error-classes branch from fa50fbd to 0d2dd59 Compare December 12, 2024 22:51
@ijjk ijjk added the tests label Dec 12, 2024
@gaojude gaojude changed the base branch from canary to exclude_error_code_for_test_files December 12, 2024 22:51
@gaojude gaojude force-pushed the exclude_error_code_for_test_files branch from 405386e to a6d8cec Compare December 12, 2024 23:21
Base automatically changed from exclude_error_code_for_test_files to canary December 13, 2024 00:08
@gaojude gaojude force-pushed the jude/more-error-classes branch from 0d2dd59 to a56c0aa Compare December 13, 2024 02:13
@gaojude gaojude merged commit c2e7c89 into canary Dec 13, 2024
112 checks passed
@gaojude gaojude deleted the jude/more-error-classes branch December 13, 2024 15:55
eps1lon
eps1lon reviewed Dec 16, 2024
View reviewed changes
crates/next-error-code-swc-plugin/src/lib.rs
@@ -16,8 +16,43 @@ struct NewError {
}

fn is_error_class_name(name: &str) -> bool {
// TODO: handle other error classes
name == "Error"
name == "AggregateError"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document how you gathered these.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eps1lon eps1lon eps1lon left review comments

@devjiwonchoi devjiwonchoi devjiwonchoi approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked tests Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaojude @ijjk @eps1lon @devjiwonchoi