Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move static paths utils into own folder #73928

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Dec 13, 2024

Modifies no code, just moving files around to simplify the upstream review.

@ijjk
Copy link
Member

ijjk commented Dec 13, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
buildDuration 21.4s 19s N/A
buildDurationCached 18.3s 16.1s N/A
nodeModulesSize 410 MB 410 MB ⚠️ +13.1 kB
nextStartRea..uration (ms) 533ms 520ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
1187-HASH.js gzip 51.1 kB 51.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 314 kB 314 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.4 kB 37.4 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39 kB 39 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/separate-static-paths-utils Change
0.pack gzip 2.06 MB 2.06 MB ⚠️ +823 B
index.pack gzip 72.3 kB 72.3 kB N/A
Overall change 2.06 MB 2.06 MB ⚠️ +823 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 21f813f

@wyattjoh wyattjoh force-pushed the 11-12-feat_rootparams branch from 32957e5 to ee411bc Compare December 14, 2024 02:04
@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from acb7423 to c957272 Compare December 14, 2024 02:04
@wyattjoh wyattjoh force-pushed the 11-12-feat_rootparams branch from ee411bc to 947da6a Compare December 16, 2024 20:05
@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from c957272 to d410536 Compare December 16, 2024 20:06
@wyattjoh wyattjoh force-pushed the 11-12-feat_rootparams branch from 947da6a to 96ada8c Compare December 16, 2024 20:10
@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from d410536 to f72a407 Compare December 16, 2024 20:11
@wyattjoh wyattjoh marked this pull request as ready for review December 16, 2024 21:41
@ztanner ztanner force-pushed the 11-12-feat_rootparams branch from 96ada8c to 481684d Compare December 16, 2024 22:06
@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from f72a407 to affef26 Compare December 16, 2024 22:16
@wyattjoh wyattjoh force-pushed the 11-12-feat_rootparams branch from 481684d to 38766b5 Compare December 16, 2024 22:29
@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from affef26 to ad7b0a5 Compare December 16, 2024 22:29
@wyattjoh wyattjoh changed the base branch from 11-12-feat_rootparams to graphite-base/73928 December 16, 2024 23:42
@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from ad7b0a5 to f5d10b6 Compare December 16, 2024 23:43
@wyattjoh wyattjoh force-pushed the graphite-base/73928 branch from 38766b5 to f76c1ae Compare December 16, 2024 23:43
@wyattjoh wyattjoh changed the base branch from graphite-base/73928 to canary December 16, 2024 23:43
@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from f5d10b6 to 20b4910 Compare December 16, 2024 23:44
@ijjk
Copy link
Member

ijjk commented Dec 16, 2024

Tests Passed

@wyattjoh wyattjoh force-pushed the chore/separate-static-paths-utils branch from 22d9c2c to 21f813f Compare December 17, 2024 16:28
@wyattjoh wyattjoh merged commit ff0ef9c into canary Dec 17, 2024
129 of 132 checks passed
Copy link
Member Author

Merge activity

  • Dec 17, 12:16 PM EST: A user merged this pull request with Graphite.

@wyattjoh wyattjoh deleted the chore/separate-static-paths-utils branch December 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants